Skip to content

chore: regenerate client, drop orphaned sandbox files#109

Merged
hotdata-automation[bot] merged 4 commits into
mainfrom
openapi-update-27246893878
Jun 10, 2026
Merged

chore: regenerate client, drop orphaned sandbox files#109
hotdata-automation[bot] merged 4 commits into
mainfrom
openapi-update-27246893878

Conversation

@hotdata-automation

@hotdata-automation hotdata-automation Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Regenerated from the current Hotdata OpenAPI spec. With the fixed clean step (#108), this removes generated files for endpoints no longer in the spec — the lingering sandbox API/models/docs/tests left over from earlier regens.

Why the diff is large

The fixed clean step (rm -rf hotdata/api hotdata/models docs test) finally regenerates artifacts that earlier regens left stale, so this one PR catches them all up:

  • test/ stubs refreshed. openapi-generator writes a model/api test stub only when absent and never overwrites an existing one, so test/ had been frozen since chore: regenerate client from updated OpenAPI spec #6 (2026-03-12) while hotdata/api/hotdata/models were regenerated every cycle. The clean step now wipes test/, so the stubs regenerate against the current spec. That's why they drop the _handler operationId suffix (removed upstream in www#21, 2026-03-12), add the managed-schema/table tests, and fix the HotDataHotdata title.
  • More orphaned files removed (not just sandbox). workspace_context_api + its models, column_definition, and the old auto-named create_workspace201_response/list_workspaces200_response (superseded by CreateWorkspaceResponse/ListWorkspacesResponse) — all confirmed absent from the current spec.
  • .openapi-generator/FILES updated to list the refreshed test files.

No live functionality is removed: workspaces_api and its current models are intact, and integration CI passes. Every deletion corresponds to something genuinely absent from the spec.

@hotdata-automation hotdata-automation Bot enabled auto-merge (squash) June 10, 2026 01:27


class TestApiClientClose(unittest.TestCase):
def test_close_does_not_raise(self) -> None:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a hand-written test, not a generated one — it's the only coverage for ApiClient.close() and the context-manager (__enter__/__exit__) behavior, which are still present in hotdata/api_client.py (lines 97–104) and unchanged by this regen. It's being deleted because the new clean step from #108 removes any file not produced by the generator and not listed in .openapi-generator-ignore, and this path isn't in either.

This means the test is silently swept up as collateral, and every future regen will keep deleting it. Add the path to .openapi-generator-ignore (alongside the other hand-maintained files like hotdata/_auth.py) and restore the file so the custom behavior stays covered:

test/test_api_client_close.py

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review — Blocking

A hand-written test is being deleted by this regen: test/test_api_client_close.py. It is not generator output — it is the only coverage for ApiClient.close() and the context-manager (__enter__/__exit__) behavior, which still ships in hotdata/api_client.py. The clean step fixed in PR 108 removes it because the path is in neither the generator output nor .openapi-generator-ignore, so every future regen will keep wiping it.

Action required: restore test/test_api_client_close.py and add its path to .openapi-generator-ignore (next to the other hand-maintained entries like hotdata/_auth.py) so the clean step preserves it.

The rest of the diff is routine regeneration churn (orphaned sandbox / workspace-context files dropped, version bump 0.3.2 -> 0.3.3) and looks correct.

@zfarrell

Copy link
Copy Markdown
Contributor

Great catch — fixed in 3e9e651, e6b09ae, 0017db9.

test/test_api_client_close.py is hand-written (single origin commit 6ad261a, absent from .openapi-generator/FILES) and covers the ApiClient.close()/__enter__/__exit__ behavior that scripts/patch_api_client_close.py re-applies each regen.

One nuance on the suggested fix: the clean step is a blanket rm -rf hotdata/api hotdata/models docs test that doesn't consult .openapi-generator-ignore, so adding the path to that file alone wouldn't have saved it — the next regen would still delete it. So the fix is two parts:

  1. Restored test/test_api_client_close.py and added it to .openapi-generator-ignore (with a comment).
  2. Made the clean step honor .openapi-generator-ignore: after the wipe it restores (git checkout --) any ignored path that falls under a cleaned subtree. .openapi-generator-ignore is now the single source of truth for "hand-maintained, don't delete," so any future hand-written file added there is preserved automatically — no recurrence.

Verified locally: YAML parses, the filter selects only test/test_api_client_close.py, and git checkout -- restores it after the rm.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prior blocking issue resolved: test/test_api_client_close.py is restored, added to .openapi-generator-ignore, and the clean step now git checkouts ignored paths back after the wipe so future regens won't delete hand-maintained code. Verified the restore loop scoping and the test coverage. LGTM.

@hotdata-automation hotdata-automation Bot merged commit b597d18 into main Jun 10, 2026
4 checks passed
@hotdata-automation hotdata-automation Bot deleted the openapi-update-27246893878 branch June 10, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant