chore: regenerate client, drop orphaned sandbox files#109
Conversation
|
|
||
|
|
||
| class TestApiClientClose(unittest.TestCase): | ||
| def test_close_does_not_raise(self) -> None: |
There was a problem hiding this comment.
This is a hand-written test, not a generated one — it's the only coverage for ApiClient.close() and the context-manager (__enter__/__exit__) behavior, which are still present in hotdata/api_client.py (lines 97–104) and unchanged by this regen. It's being deleted because the new clean step from #108 removes any file not produced by the generator and not listed in .openapi-generator-ignore, and this path isn't in either.
This means the test is silently swept up as collateral, and every future regen will keep deleting it. Add the path to .openapi-generator-ignore (alongside the other hand-maintained files like hotdata/_auth.py) and restore the file so the custom behavior stays covered:
test/test_api_client_close.py
There was a problem hiding this comment.
Review — Blocking
A hand-written test is being deleted by this regen: test/test_api_client_close.py. It is not generator output — it is the only coverage for ApiClient.close() and the context-manager (__enter__/__exit__) behavior, which still ships in hotdata/api_client.py. The clean step fixed in PR 108 removes it because the path is in neither the generator output nor .openapi-generator-ignore, so every future regen will keep wiping it.
Action required: restore test/test_api_client_close.py and add its path to .openapi-generator-ignore (next to the other hand-maintained entries like hotdata/_auth.py) so the clean step preserves it.
The rest of the diff is routine regeneration churn (orphaned sandbox / workspace-context files dropped, version bump 0.3.2 -> 0.3.3) and looks correct.
|
Great catch — fixed in 3e9e651, e6b09ae, 0017db9.
One nuance on the suggested fix: the clean step is a blanket
Verified locally: YAML parses, the filter selects only |
There was a problem hiding this comment.
Prior blocking issue resolved: test/test_api_client_close.py is restored, added to .openapi-generator-ignore, and the clean step now git checkouts ignored paths back after the wipe so future regens won't delete hand-maintained code. Verified the restore loop scoping and the test coverage. LGTM.
Regenerated from the current Hotdata OpenAPI spec. With the fixed clean step (#108), this removes generated files for endpoints no longer in the spec — the lingering sandbox API/models/docs/tests left over from earlier regens.
Why the diff is large
The fixed clean step (
rm -rf hotdata/api hotdata/models docs test) finally regenerates artifacts that earlier regens left stale, so this one PR catches them all up:test/stubs refreshed. openapi-generator writes a model/api test stub only when absent and never overwrites an existing one, sotest/had been frozen since chore: regenerate client from updated OpenAPI spec #6 (2026-03-12) whilehotdata/api/hotdata/modelswere regenerated every cycle. The clean step now wipestest/, so the stubs regenerate against the current spec. That's why they drop the_handleroperationId suffix (removed upstream in www#21, 2026-03-12), add the managed-schema/table tests, and fix theHotData→Hotdatatitle.workspace_context_api+ its models,column_definition, and the old auto-namedcreate_workspace201_response/list_workspaces200_response(superseded byCreateWorkspaceResponse/ListWorkspacesResponse) — all confirmed absent from the current spec..openapi-generator/FILESupdated to list the refreshed test files.No live functionality is removed:
workspaces_apiand its current models are intact, and integration CI passes. Every deletion corresponds to something genuinely absent from the spec.