Skip to content

ci: drop toolchain pin, allow upstream clippy lints #2

Merged
shefeek-jinnah merged 1 commit intomainfrom
shefeek-jinnah-patch-1
Apr 28, 2026
Merged

ci: drop toolchain pin, allow upstream clippy lints #2
shefeek-jinnah merged 1 commit intomainfrom
shefeek-jinnah-patch-1

Conversation

@shefeek-jinnah
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion below, but this is a reasonable change — no blocking issues.

Comment thread .github/workflows/ci.yml
@@ -20,7 +20,6 @@ jobs:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Consider adding a rust-toolchain.toml at the repo root instead of (or alongside) controlling the version here. That file is picked up by both cargo and rustup automatically, so local dev and CI stay in sync without any special CI config — and bumping the toolchain is a single-file change that shows up clearly in git history. (not blocking)

@shefeek-jinnah shefeek-jinnah merged commit 64fbd92 into main Apr 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant