Skip to content

feat(connections): Add connections schema refresh command#13

Merged
pthurlow merged 1 commit into
mainfrom
feat/conn-refresh
Mar 24, 2026
Merged

feat(connections): Add connections schema refresh command#13
pthurlow merged 1 commit into
mainfrom
feat/conn-refresh

Conversation

@pthurlow

Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread src/connections.rs
claude[bot]
claude Bot previously requested changes Mar 23, 2026

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

  • src/connections.rs:354 — The refresh endpoint URL is {api_url}/refresh, but every other connection operation in this file uses a path under /connections (e.g. /connections, /connection-types/{name}). This will 404 at runtime. The URL should be {}/connections/{connection_id}/refresh or {}/connections/refresh depending on the API's design.

Action Required

Fix the endpoint URL before merging. If the intended API route keeps connection_id in the request body, use /connections/refresh. If it uses a RESTful path parameter, use /connections/{connection_id}/refresh (and the body field can be dropped).

@pthurlow pthurlow merged commit 5b5421f into main Mar 24, 2026
7 checks passed
@pthurlow pthurlow deleted the feat/conn-refresh branch March 24, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant