feat(local): stock Dory integration + self-hosted smoke - #84
Open
patrickleet wants to merge 3 commits into
Open
Conversation
Rebuild the dory backend around product k3s + an engine-side registry: host push localhost:30500, cluster pull host.dory.internal:30500. Drop ports/registries create-time files and in-cluster NodePort on dory. Crossplane still installs the same; package pull address is backend-aware.
hops no longer calls dory k8s enable/disable or requires a scriptable CLI. Users enable Kubernetes in the Dory app; hops starts a stopped dory-k8s node, waits for Ready, and uses the engine package bridge. Destroy/reset only remove the container via the engine docker socket.
Use product Dory only (dory.sock, hops-dory desktop, TLS registry push via engine bridge). Add HOPS_DORY_DESKTOP=0 for env-only sessions that do not mutate host kube/docker defaults. Rewrite dory CI for self-hosted Apple Silicon (label hops-dory / test-dory): no fork build, no Colima sock surrogate, soft cleanup only. Add tests/fixtures/config-smoke and path-based hops config install in smoke (namespaced ConfigMap under hops-ci).
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dory k8s enable): productdory.sock, app-owned k3s (dory-k8s), desktop contexthops-dory(optional--name/HOPS_DORY_NAME).{dory-k8s-ip}:30500with TLS registry + CA wiring. Drop host-gateway / Colima sock theater.HOPS_DORY_DESKTOP=0drives sessions viaDOCKER_HOST+KUBECONFIGonly (nouse-context/ docker context mutation) — safe for a personal Mac runner.runs-on: [self-hosted, macOS, ARM64, hops-dory], labeltest-dory): real engine, soft cleanup (no destroy/stop/rm k8s), path-based config install.tests/fixtures/config-smoke:hops config install --path …builds a minimal ConfigMap XR under namespacehops-ci.Stacks on #70 (
feat/cluster-backend-abstraction).Test plan
cargo test --test dory_smoke_workflow(structural CI contract)hops config install --path tests/fixtures/config-smoke→ ConfigSmoke Ready + ConfigMapsmoke: oktest-dory+ self-hosted runner./run.shon Apple Silicon with Dory engine + k8s +upon PATHhops-cionlyNotes
dory-hv; Colima-as-dory.sockwas intentionally removed.HV_BAD_ARGUMENTdocumented in README; pin smaller memory in the Dory app.