HDPI-7307: Email following successful cc payment - #2334
Open
nicole-samuels wants to merge 21 commits into
Open
Conversation
CCD diff summary👉 Full report: https://github.com/hmcts/pcs-api/actions/runs/31017013216?check_suite_focus=true No change |
nicole-samuels
changed the base branch from
master
to
HDPI-5794_Update_LR_contact_details
August 6, 2026 11:27
…il-following-successful-CC-payment # Conflicts: # src/main/java/uk/gov/hmcts/reform/pcs/ccd/event/respondpossessionclaim/strategy/LegalRepSubmissionEventStrategy.java # src/test/java/uk/gov/hmcts/reform/pcs/ccd/event/RespondPossessionClaimTest.java # src/test/java/uk/gov/hmcts/reform/pcs/ccd/event/respondpossessionclaim/strategy/LegalRepSubmissionEventStrategyTest.java
…nterclaimPaymentSuccessPersonalisation
…il-following-successful-CC-payment
nicole-samuels
marked this pull request as ready for review
August 7, 2026 10:04
nicole-samuels
requested review from
linusnorton
and removed request for
a team
August 7, 2026 10:04
nicole-samuels
requested review from
jonathanditcher-solirius and
sk-karimi1
and removed request for
a team
August 7, 2026 10:04
| } | ||
|
|
||
| return submitResponse; | ||
| } |
Contributor
There was a problem hiding this comment.
Minor - what was the reason for splitting this out into a separate local variable?
Contributor
Author
There was a problem hiding this comment.
I've reverted it back to an inline return
| : formatNameUpperForNotification(primaryClaimant.getFirstName(), primaryClaimant.getLastName()); | ||
|
|
||
| String primaryDefendantName = getDefendantName( | ||
| primaryDefendant.getNameKnown() != null && primaryDefendant.getNameKnown().toBoolean(), |
Contributor
There was a problem hiding this comment.
Minor - you could use YesOrNoConverter.toBoolean() for this, which is null safe.
| @RequestHeader(value = "ServiceAuthorization") String serviceAuthorization, | ||
| @RequestParam Integer defendantResponseId) { | ||
|
|
||
| // legalRepSubmissionEventStrategy.process(null); |
Contributor
There was a problem hiding this comment.
Can this be removed?
| api-url: ${NOTIFY_URL:http://localhost:8083} | ||
| api-key: ${PCS_NOTIFY_API_KEY:AAAAAAAA-AAAA-AAAA-AAAA-AAAAAAAAAAAA} | ||
| # PLEASE DON'T CHECK IN | ||
| api-key: lucastestkey-d83dc897-57d7-4093-891e-2367b79f22a9-cf2f5419-2568-4e2d-8510-bf207c90810b |
Contributor
There was a problem hiding this comment.
This shouldn't have been checked in. You can set the PCS_NOTIFY_API_KEY environment variable instead in your run configuration
Contributor
Author
There was a problem hiding this comment.
Noted, this has been removed
…aced email template for legal rep, removed unused imports
scottstewart-sl
approved these changes
Aug 10, 2026
…il-following-successful-CC-payment
nicole-samuels
changed the base branch from
HDPI-5794_Update_LR_contact_details
to
HDPI-6643_counterclaim_lr_payment
August 12, 2026 13:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira link
See HDPI-7307
Change description
Added a base personalisation for a legal representative and introduced counterclaim success notification for the legal representative.
Testing done
Manual testing in progress
Security Vulnerability Assessment
CVE Suppression: Are there any CVEs present in the codebase (either newly introduced or pre-existing) that are being intentionally suppressed or ignored by this commit?
Checklist