Skip to content

feat(shader-transitions): optional shader field — CSS crossfade mixing in HyperShader #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ukimsanov wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(shader-transitions): optional shader field — CSS crossfade mixing in HyperShader #886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/engine/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ export interface HfTransitionMeta {
time: number;
/** Transition duration (seconds) */
duration: number;
/** Shader identifier (e.g. "fade", "wipe") */
shader: string;
/** Shader identifier. Undefined when the transition is a CSS crossfade. */
shader?: string;
/** GSAP easing string (e.g. "power2.inOut") */
ease: string;
/** Scene id the transition starts from */
Expand Down
25 changes: 15 additions & 10 deletions packages/shader-transitions/src/hyper-shader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ interface GsapTimeline {

export interface TransitionConfig {
time: number;
shader: ShaderName;
/** Omit to use a CSS crossfade instead of a WebGL shader. */
shader?: ShaderName;
duration?: number;
ease?: string;
}
Expand Down Expand Up @@ -98,7 +99,7 @@ interface CachedTransition {
duration: number;
fromId: string;
toId: string;
prog: WebGLProgram;
prog: WebGLProgram | null; // null for CSS-fallback transitions
frames: CachedTransitionFrame[];
cacheKey: string;
dirty: boolean;
Expand Down Expand Up @@ -823,7 +824,7 @@ export function init(config: HyperShaderConfig): GsapTimeline {
interface HfTransitionMeta {
time: number;
duration: number;
shader: string;
shader?: string; // undefined = CSS crossfade (no WebGL required)
ease: string;
fromScene: string;
toScene: string;
Expand Down Expand Up @@ -900,6 +901,7 @@ export function init(config: HyperShaderConfig): GsapTimeline {

const programs = new Map<string, WebGLProgram>();
for (const t of transitions) {
if (!t.shader) continue; // CSS-only transitions have no WebGL program
if (!programs.has(t.shader)) {
try {
programs.set(t.shader, createProgram(gl, getFragSource(t.shader)));
Expand Down Expand Up @@ -1162,7 +1164,7 @@ export function init(config: HyperShaderConfig): GsapTimeline {
renderShader(
gl,
quadBuf,
state.prog,
state.prog!, // non-null: fallback path returns before reaching here
interpolatedFromTex,
interpolatedToTex,
state.progress,
Expand Down Expand Up @@ -1291,8 +1293,11 @@ export function init(config: HyperShaderConfig): GsapTimeline {
const toId = scenes[i + 1];
if (!fromId || !toId) continue;

const prog = programs.get(t.shader);
if (!prog) continue;
// CSS-only transition when shader is omitted — uses the fallback opacity
// crossfade path. No WebGL program or texture prewarming needed.
const isCssFallback = !t.shader;
const prog = isCssFallback ? null : (programs.get(t.shader!) ?? null);
if (!isCssFallback && !prog) continue; // shader requested but not compiled

const dur = t.duration ?? DEFAULT_DURATION;
const ease = t.ease ?? DEFAULT_EASE;
Expand All @@ -1307,10 +1312,10 @@ export function init(config: HyperShaderConfig): GsapTimeline {
prog,
frames: [],
cacheKey: "",
dirty: true,
ready: false,
fallback: false,
persisted: false,
dirty: !isCssFallback,
ready: isCssFallback, // CSS fallback needs no prewarming
fallback: isCssFallback,
persisted: isCssFallback,
textureReady: false,
texturePromise: null,
textureGeneration: 0,
Expand Down
Loading