fix(player/runtime): rebind timelines and bound paused seeks - #3489
Open
vanceingalls wants to merge 7 commits into
Open
Conversation
Collaborator
Author
|
@claude review |
Collaborator
Author
|
@claude review |
Collaborator
Author
|
Post-push verification update:
No code changes are pending; awaiting the fresh review approval. |
Collaborator
Author
miga-heygen
force-pushed
the
vance/captions-convergence-03-direct-timeline-rebind
branch
from
August 26, 2026 07:48
1b7e265 to
87a62ea
Compare
Collaborator
Author
|
CPU-stability update at
@claude review |
Collaborator
Author
|
Final-head automation update for
The remaining gate is human review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3 of 3 in the HyperFrames caption convergence stack. Depends on #3472.
What changes
runtime-data-applied, so an immediate seek cannot clamp against the initial timeline.runtime-srcoverride for pairing a branch-tip player with its matching branch-tip core in an authorized local rig; unsafe schemes fall back to the pinned CDN runtime.Why
Data-driven caption attach rebuilds the GSAP timeline. The direct player adapter and the injected runtime could retain the killed initial object, leaving playback on segment one. Real-browser validation exposed three additional ordering hazards: React can assign
srcdocbefore connection, the runtime ready message can precede iframeload, and a replacement could be acknowledged before its new duration was published.Verification
HyperFrames core: 124 test files / 2,542 tests passed; focused runtime tests, typecheck, build, oxlint, and oxfmt passed.
Player: 12 test files / 360 tests passed; build, typecheck, oxlint, and oxfmt passed.
Historical exact-browser proof against catalog 0.6.0 and the matching branch-tip core: create with React's
srcdocthenruntime-srcordering; apply three segments; switchcaption-highlighttocaption-pill-karaoke; immediately seek to 0.2s, 1.7s, and 3.2s after each apply. Both styles reported duration 3.9s and landed all seeks exactly; the old player disconnected, the bridge stayed ready, and no runtime-data error fired.Current-head CI, Windows rendering, player performance, preview regression, CodeQL, and all nine regression shards are green.
Review size
390 additions and 9 deletions across 5 files, below the 1,500-line stack limit.