Skip to content

refactor(producer): delete the dead audioExtractor duplicate #3389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vanceingalls wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor(producer): delete the dead audioExtractor duplicate #3389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
996c6e2
refactor(producer): delete the dead audioExtractor duplicate
vanceingalls Aug 21, 2026
bc43269
chore: record the audioExtractor deletion in the no-deletions guard
vanceingalls Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
323 changes: 0 additions & 323 deletions packages/producer/src/services/audioExtractor.ts
View file
Open in desktop

This file was deleted.

4 changes: 4 additions & 0 deletions scripts/check-no-main-deletions.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,10 @@ export const ALLOWED_DELETIONS = new Map([
"packages/core/scripts/build-position-edits-render.ts",
"merged into build-inline-artifact.ts, same reason as build-audio-fx-runtime.ts above",
],
[
"packages/producer/src/services/audioExtractor.ts",
"dead duplicate of engine's audioMixer: its processAudio had no callers and its parseAudioElements was shadowed by the @hyperframes/engine export every live consumer already imports (audioMixer.ts re-exports it, renderMediaCollector.ts and the playback-rate fixture import it directly). PRINFRA-349's review found the copy's hand-rolled source-path join reproducing the percent-encoded-CJK bug the engine resolver does not have — deleting the copy is the fix",
],
[
"packages/core/scripts/build-inline-artifact.ts",
"a later branch in this stack (wa-20b2-lfo-fixes) independently deduped the same two build scripts a different way — buildInjectedArtifact.ts plus two thin per-target files — before this consolidation and that one had merged; this branch's tree keeps that shape instead, so build-inline-artifact.ts is the one that goes.",
Expand Down
Loading