feat(studio): arrow-key nudge step math (unwired)#2203
Open
ukimsanov wants to merge 1 commit into
Open
Conversation
This was referenced Jul 11, 2026
Collaborator
Author
This was referenced Jul 11, 2026
ukimsanov
force-pushed
the
studio-dnd/pr12-canvas-nudge-math
branch
from
a5ce90b to
f6dd7eb
Compare
ukimsanov
force-pushed
the
studio-dnd/pr11-canvas-zorder-menu
branch
from
9d0fa02 to
78c55d1
Compare
ukimsanov
force-pushed
the
studio-dnd/pr12-canvas-nudge-math
branch
from
f6dd7eb to
f45f759
Compare
miga-heygen
reviewed
Jul 11, 2026
miga-heygen
left a comment
miga-heygen
left a comment
Contributor
There was a problem hiding this comment.
Reviewed as part of the 25-PR NLE overhaul stack. Full stack review on #2205 (the keystone). No blockers on this PR. — Miga
vanceingalls
left a comment
vanceingalls
left a comment
Collaborator
There was a problem hiding this comment.
Verdict: LGTM (green) — smallest of the batch, correct at every boundary
Two pure helpers: resolveCanvasNudgeDelta maps arrow keys (plain / Shift) to a { dx, dy } in composition pixels; canCanvasNudgeTargets gates the whole nudge on target capabilities. Nothing to trip over.
The pointed queries
- Step math is unambiguous.
packages/studio/src/components/editor/domEditNudge.ts:11–:12—CANVAS_NUDGE_STEP_PX = 1,CANVAS_NUDGE_SHIFT_STEP_PX = 10. Constants are integers in composition-space pixels; the returned{ dx, dy }is likewise in pixels. Test at :24–:52 pins all four cardinal directions × {plain, Shift}. - Chord passthrough. :28 rejects
metaKey || ctrlKey || altKey→ returnsnullso browser/app shortcuts route past the nudge. Tested at :54–:58 for all three modifiers. Correct. - Non-arrow rejection. :29 gates on
CANVAS_NUDGE_KEYS.has(event.key); non-arrows fall through tonull. Tested at :60–:63. - Target-capability gate.
canCanvasNudgeTargetsat :42–:44 requires at least one target AND every target'scanApplyManualOffset === true. Test at :66–:79 covers[](false),[movable](true),[movable, movable](true),[locked](false),[movable, locked](false). All four boundary cases. - Debounce constant. :14 (
CANVAS_NUDGE_COMMIT_DEBOUNCE_MS = 400) is exported but not yet consumed at this SHA — exempted in.fallowrc.jsoncat :93–:97 with the TEMP marker pointing at studio-dnd/pr22. Honest. - No accumulation logic here. Delta accumulation for holding an arrow key (the "burst commit" pattern named in the docstring at :13) is NOT in this file — it belongs to the wiring PR. This module is a pure per-event mapper. Right scope.
- Wiring with
#2200(canvas nudge gate). No import at this SHA — verified via grep againstDomEditOverlay.tsxhead. As with#2200, the pair is expected to be wired together by studio-dnd/pr22. This PR's math is independently testable and it is tested.
R1 by Via
ukimsanov
force-pushed
the
studio-dnd/pr12-canvas-nudge-math
branch
from
f45f759 to
a15be5a
Compare
ukimsanov
force-pushed
the
studio-dnd/pr11-canvas-zorder-menu
branch
from
ad7cd13 to
97977b2
Compare
ukimsanov
force-pushed
the
studio-dnd/pr12-canvas-nudge-math
branch
from
a15be5a to
f20cc98
Compare
ukimsanov
force-pushed
the
studio-dnd/pr12-canvas-nudge-math
branch
from
f20cc98 to
f3e5bb2
Compare
ukimsanov
force-pushed
the
studio-dnd/pr11-canvas-zorder-menu
branch
from
143e573 to
a087215
Compare
What: domEditNudge — pure nudge-step math (direction × modifier → delta, commit debounce constant) with tests. Shipped unwired. Why: small standalone concept consumed by the canvas nudge hook in the chrome-components PR. How: new files; one TEMP(studio-dnd) ignoreExports entry until the consumer lands (removed by the app-shell swap PR). Test plan: bunx vitest run domEditNudge.test.ts; tsc --noEmit; fallow audit clean.
ukimsanov
force-pushed
the
studio-dnd/pr12-canvas-nudge-math
branch
from
f3e5bb2 to
b72f457
Compare
ukimsanov
force-pushed
the
studio-dnd/pr11-canvas-zorder-menu
branch
from
a087215 to
802df15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
domEditNudge — pure nudge-step math (direction × modifier → delta, commit debounce constant) with tests. Shipped unwired.
Why
small standalone concept consumed by the canvas nudge hook in the chrome-components PR.
How
new files; one TEMP(studio-dnd) ignoreExports entry until the consumer lands (removed by the app-shell swap PR).
Test plan
bunx vitest run domEditNudge.test.ts; tsc --noEmit; fallow audit clean.
Stack position 12/25 — studio NLE overhaul (CapCut-parity timeline + canvas). Graphite manages bases; merge from #2192 upward. Temporary
TEMP(studio-dnd)fallow entries (unwired-component windows) are all removed by #2213 (app-shell swap), whose tree is byte-identical to the fully-verified integration branch.