fix(cli): actionable remediation for chrome-headless-shell SIGTRAP on arm64 macOS [P2]#2078
Draft
miguel-heygen wants to merge 1 commit into
Draft
fix(cli): actionable remediation for chrome-headless-shell SIGTRAP on arm64 macOS [P2]#2078miguel-heygen wants to merge 1 commit into
miguel-heygen wants to merge 1 commit into
Conversation
… arm64 macOS On arm64 macOS the bundled chrome-headless-shell can crash with SIGTRAP (EXC_BREAKPOINT) at launch, and the render fails with no guidance. Confirmed on an arm64 macOS 26.5.1 machine with 21 chrome-headless-shell trap crash reports in DiagnosticReports, including crashes against builds NEWER than the current pin, so bumping CHROME_VERSION is an unverified gamble with a repo-wide blast radius. Surface an actionable error instead. macosChromeCrashRemediation() (darwin+arm64-gated; reuses isTransientBrowserError from the engine, no duplicated regex) wired into handleRenderError after the Linux chromeLaunchRemediation check; surfaces the --docker / HYPERFRAMES_DOCKER_PLATFORM=linux/amd64 and HYPERFRAMES_BROWSER_PATH workarounds. CHROME_VERSION and the Linux path untouched. 7 tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
On arm64 macOS the bundled chrome-headless-shell can crash with SIGTRAP (EXC_BREAKPOINT) at launch; the render then fails with no guidance. Reported darwin/arm64 macOS 26 (0.7.42); confirmed on an arm64 macOS 26.5.1 machine with 21 chrome-headless-shell trap crash reports in DiagnosticReports.
Why not bump the pinned version
Crashes were observed against builds newer than the current pin (
CHROME_VERSION), so a bump is an unverified gamble with a repo-wide blast radius. Chose the lower-risk actionable-error path.Fix
macosChromeCrashRemediation()(darwin+arm64-gated; reusesisTransientBrowserErrorfrom the engine, no duplicated regex) wired intohandleRenderErrorafter the LinuxchromeLaunchRemediationcheck. Surfaces--docker/HYPERFRAMES_DOCKER_PLATFORM=linux/amd64+HYPERFRAMES_BROWSER_PATH.CHROME_VERSION+ Linux path untouched.Tests
+7 (platform/arch gating + message). Full build + typecheck + oxfmt/oxlint clean.