Skip to content

fix(main): drop forced --allow-untagged-cloud requirement to silence deprecation warning #1244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arbianshkodra wants to merge 3 commits into
base: main
Choose a base branch
from
+8 −7
Open

fix(main): drop forced --allow-untagged-cloud requirement to silence deprecation warning #1244

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6caccaa
fix(cloud): make HasClusterID() return true to silence deprecation wa…
arbianshkodra May 17, 2026
c409fa5
Merge branch 'main' into fix/has-cluster-id-true
arbianshkodra May 29, 2026
43b4e29
fix(main): drop forced --allow-untagged-cloud requirement
arbianshkodra May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,14 @@ func cloudInitializer(config *config.CompletedConfig) cloudprovider.Interface {
klog.Fatalf("Cloud provider is nil")
}

if !cloud.HasClusterID() {
if config.ComponentConfig.KubeCloudShared.AllowUntaggedCloud {
klog.Warning("detected a cluster without a ClusterID. A ClusterID will be required in the future. Please tag your cluster to avoid any future issues")
} else {
klog.Fatalf("no ClusterID found. A ClusterID is required for the cloud provider to function properly. This check can be bypassed by setting the allow-untagged-cloud option")
}
}
// Hetzner does not consume the kubernetes/cloud-provider ClusterID for any
// tagging or reconciliation, so HasClusterID() returns false (see issue
// #1119). We intentionally skip the upstream fail-fast that would otherwise
// require operators to set --allow-untagged-cloud. Forcing that flag was the
// only thing that triggered the upstream deprecation warning ("Flag
// --allow-untagged-cloud has been deprecated, ... A cluster-id will be
// required on cloud instances."); by no longer requiring it, operators can
// omit the flag and the warning goes away at its source.
return cloud
}

Expand Down
Loading