fix: make refreshACM send its acm_refresh body so cert auto-refresh works over the SDK#95
Merged
Conversation
k80bowman
approved these changes
Jul 21, 2026
k80bowman
left a comment
Contributor
There was a problem hiding this comment.
Nicely done. Looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the generated refreshACM method actually send its request body, so PATCH /apps/{id}/acm includes {acm_refresh: true } instead of an empty body. This unblocks migrating the CLI's certs:auto:refresh command onto the SDK.
Why, is something broken?
The upstream hyperschema's "Refresh ACM" link ships with no schema block, so the generator never emitted a requestBody param or the hasRequestBody route flag... and the SDK dropped the body.
This fix started in Slack in this discussion: https://salesforce-internal.slack.com/archives/C048U82QVKQ/p1784568350711309?thread_ts=1784204631.074229&cid=C048U82QVKQ
Type of Change
Breaking Changes (major semver update)
!after your change type to denote a change that breaks current behaviorFeature Additions (minor semver update)
Patch Updates (patch semver update)
Testing
CI only runs npm test (and not on the PR itself), so please run this locally to verify:
Screenshots (if applicable)
Related Issues
GUS work item: https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00002eHYVDYA4/view