Skip to content

fix: make refreshACM send its acm_refresh body so cert auto-refresh works over the SDK#95

Merged
jdodson merged 2 commits into
mainfrom
jbd_fix_auto_refresh
Jul 21, 2026
Merged

fix: make refreshACM send its acm_refresh body so cert auto-refresh works over the SDK#95
jdodson merged 2 commits into
mainfrom
jbd_fix_auto_refresh

Conversation

@jdodson

@jdodson jdodson commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Makes the generated refreshACM method actually send its request body, so PATCH /apps/{id}/acm includes {acm_refresh: true } instead of an empty body. This unblocks migrating the CLI's certs:auto:refresh command onto the SDK.

Why, is something broken?

The upstream hyperschema's "Refresh ACM" link ships with no schema block, so the generator never emitted a requestBody param or the hasRequestBody route flag... and the SDK dropped the body.

This fix started in Slack in this discussion: https://salesforce-internal.slack.com/archives/C048U82QVKQ/p1784568350711309?thread_ts=1784204631.074229&cid=C048U82QVKQ

Type of Change

Breaking Changes (major semver update)

  • Add a ! after your change type to denote a change that breaks current behavior

Feature Additions (minor semver update)

  • feat: Introduces a new feature to the codebase

Patch Updates (patch semver update)

  • fix: Bug fix
  • deps: Dependency upgrade
  • revert: Revert a previous commit
  • chore: Change that does not affect production code
  • refactor: Refactoring existing code without changing behavior
  • test: Add/update/remove tests

Testing

CI only runs npm test (and not on the PR itself), so please run this locally to verify:

  • npm test # 127/127, includes the golden byte-for-byte test — the real correctness gate
  • npm run typecheck # clean (CI does NOT run this)
  • grep -A3 '"refreshACM"' dist/3.sdk/routes.js # shows "hasRequestBody": true
  • grep -n AppRefreshACMOpts dist/3.sdk/types.d.ts # interface + param present

Screenshots (if applicable)

Related Issues

GUS work item: https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00002eHYVDYA4/view

@jdodson
jdodson requested a review from a team as a code owner July 20, 2026 22:12

@k80bowman k80bowman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. Looks good.

@jdodson
jdodson merged commit dca680d into main Jul 21, 2026
1 check passed
@jdodson
jdodson deleted the jbd_fix_auto_refresh branch July 21, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants