Skip to content

Don't cancel merged requests#1706

Merged
andrey-kashcheev merged 1 commit into
masterfrom
datasdk-101-named-mutex-cancel
Jul 3, 2026
Merged

Don't cancel merged requests#1706
andrey-kashcheev merged 1 commit into
masterfrom
datasdk-101-named-mutex-cancel

Conversation

@andrey-kashcheev

Copy link
Copy Markdown
Collaborator

Cancellation is not an error and shouldn't be propagated to parallel requests

Relates-To: DATASDK-101

@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.30%. Comparing base (8fdc782) to head (cb684f0).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1706      +/-   ##
==========================================
+ Coverage   80.29%   80.30%   +0.01%     
==========================================
  Files         356      356              
  Lines       14280    14282       +2     
  Branches     1562     1564       +2     
==========================================
+ Hits        11465    11468       +3     
- Misses       2183     2184       +1     
+ Partials      632      630       -2     
Files with missing lines Coverage Δ
...k-dataservice-read/src/repositories/NamedMutex.cpp 89.87% <100.00%> (-3.72%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Cancellation is not an error and shouldn't be propagated
to parallel requests

Relates-To: DATASDK-101

Signed-off-by: Andrey Kashcheev <ext-andrey.kashcheev@here.com>
@andrey-kashcheev andrey-kashcheev force-pushed the datasdk-101-named-mutex-cancel branch from b5adf1b to cb684f0 Compare July 3, 2026 13:47
@andrey-kashcheev andrey-kashcheev merged commit be2513d into master Jul 3, 2026
28 checks passed
@andrey-kashcheev andrey-kashcheev deleted the datasdk-101-named-mutex-cancel branch July 3, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants