docs(go): document build_addr relative pkg resolution - #85
Merged
Conversation
heph.go.build_addr's pkg argument now accepts a ./ or ../ path relative to the calling BUILD file's package (hephbuild/heph#295). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015jVVx4PndzUBvV5MbQLrdh
⚡ Cloudflare Pages preview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
heph.go.build_addr(pkg, variant)'spkgargument now accepts a./- or../-relative path, resolved against the calling BUILD file's package (mirroring how relative addresses already work), in addition to an absolute package path.website/docs/plugins/go.md(function table + the build-variants usage section, with an example) and its reference twinplugins/heph-go/skills/heph-go/references/go-plugin.md, per the reference-drift rule in this repo'sCLAUDE.md.Triggered by hephbuild/heph@e9fa09b (hephbuild/heph#295).
Test plan
crates/model/src/htpkg/pkg.rs::join_rel_checked_pkgonmaster(dot/dot-dot resolution, escape-the-root error) rather than assuming.Generated by Claude Code