Skip to content

"[Sonic Frontiers] "Gameplay/Skills/Allow Boost to Damage Objects": Fixed Damage Collision turning off when changing to states that alredy has Damage Collision enabled"#266

Open
aleprime2007 wants to merge 7 commits into
hedge-dev:mainfrom
aleprime2007:main

Conversation

@aleprime2007

Copy link
Copy Markdown
Contributor

No description provided.

…xed Damage Collision turning off when changing to states that alredy has Damage Collision enabled
@aleprime2007 aleprime2007 changed the title "[Sonic Frontiers] \"Gameplay/Skills/Allow Boost to Damage Objects\": Fixed Damage Collision turning off when changing to states that alredy has Damage Collision enabled" "[Sonic Frontiers] "Gameplay/Skills/Allow Boost to Damage Objects": Fixed Damage Collision turning off when changing to states that alredy has Damage Collision enabled" Jul 2, 2026

@hyperbx hyperbx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from these suggestions, could you possibly provide steps to reproduce the bug this fixes? I couldn't seem to find a scenario where damage collision was set improperly.

The code seems fine, so it's not a blocker, just curious.

Comment thread Source/Sonic Frontiers/Gameplay/Skills/Allow Boost to Damage Objects.hmm Outdated
Comment thread Source/Sonic Frontiers/Gameplay/Skills/Allow Boost to Damage Objects.hmm Outdated
Comment thread Source/Sonic Frontiers/Gameplay/Skills/Allow Boost to Damage Objects.hmm Outdated
Comment thread Source/Sonic Frontiers/Gameplay/Skills/Allow Boost to Damage Objects.hmm Outdated
Comment thread Source/Sonic Frontiers/Gameplay/Skills/Allow Boost to Damage Objects.hmm Outdated
@aleprime2007

Copy link
Copy Markdown
Contributor Author

The suggested changes has been maded

@aleprime2007

aleprime2007 commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Aside from these suggestions, could you possibly provide steps to reproduce the bug this fixes? I couldn't seem to find a scenario where damage collision was set improperly.

The code seems fine, so it's not a blocker, just curious.

The bugs happend when for example, you stop boosting while jumping. The Damage Collision deactivates when it shoudn't.
Another bug happend when you hit the ground and change to StateRun, for some reason the Damage Collision turns off.
This version of the code fixes those bugs.

@aleprime2007 aleprime2007 requested a review from hyperbx July 5, 2026 03:45
@aleprime2007

aleprime2007 commented Jul 5, 2026

Copy link
Copy Markdown
Contributor Author

Sorry, I re-requested the review because I commited the changes from my computer ando not directly from github.

Is my second time making a pull request XD

@hyperbx

hyperbx commented Jul 5, 2026

Copy link
Copy Markdown
Member

Requesting a review after a code change is the norm, you're good.

Your last commit though is changing the file mode for all files on the repository. Please correct this by reverting the commit and committing only the relevant file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants