Replace local serialize.ts with @haverstack/wire-types#27
Merged
Conversation
Delete src/lib/serialize.ts and update the four route files that imported from it to pull serializeRecord, serializeType, serializeVersion, and parseDate from the shared package instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@haverstack/wire-typesas a dependencysrc/lib/serialize.ts— the wire types and serialization functions it defined are now owned by the shared packageserialize.tsto importserializeRecord,serializeType,serializeVersion, andparseDatedirectly from@haverstack/wire-typesMotivation
src/lib/serialize.tswas a local copy of what is now@haverstack/wire-types. With the package published, there's no reason to maintain a duplicate. Any future changes to the wire format happen in one place and both the server andadapter-apipick them up on the next version bump.Generated by Claude Code