fix: move check for posix_spawn_file_actions{,_np} to runtime#375
Draft
MangoIV wants to merge 1 commit into
Draft
fix: move check for posix_spawn_file_actions{,_np} to runtime#375MangoIV wants to merge 1 commit into
MangoIV wants to merge 1 commit into
Conversation
to avoid issues with symbols not being available on macos, we move the
check for the existance of posix_spawn_file_actions_addchdir{,np}
entirely to the runtime.
Member
|
Can you please let me know the timeline that this is needed in? Is this a blocker for a GHC release? |
Contributor
Author
|
@tomjaguarpaw yes, so it’s rather urgent but it’s not ready yet, I have to do a bit more investigation |
Member
|
OK, please ping me when you have something urgent I need to do. |
Contributor
Author
|
I still think ideally we should move all the checking to runtime since configure might give us all sorts of non-sense (cf. the recent macos issues) and is in comparison "cheap". |
Contributor
Author
|
E.g. I'm dreading the moment apple will remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to avoid issues with symbols not being available on macos, we move the check for the existance of posix_spawn_file_actions_addchdir{,np} entirely to the runtime.
The gist is that when testing the RC for 9.12.5, I found another issue with symbols not being there when they were configured to be. To avoid this issue altogether I moved the check to the runtime by first creating a weak symbol for the two functions and then the linker will overwrite it if available.