Add suggested fix for unbuildable ghc-bignum#11983
Open
philderbeast wants to merge 3 commits into
Open
Conversation
4642b62 to
598b93d
Compare
598b93d to
384e922
Compare
Collaborator
|
This is an improvement, but does not fix #11356. The problem is that a problematic bound on For example, used to say Not anymore with Even if you extend this error with "Note: This version of base is not reinstallable. Suggestion: Bump upper bounds on base to allow a reinstallable version", it still gives no clue which package needs bounds relaxed. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #11356.
This adds a note and suggestion when
basehas a dependency on an unbuildableghc-bignum. Aside fromtransformProgressCtx, changes are local to where the message is generated. WithintoConfiguredComponentwe don't know the version of GHC.Manual QA Notes
Here's the changed behaviour, from the reproduction of #11356 (comment) with
cabal-fmt:$ cabal freeze Error: Dependency on unbuildable library from ghc-bignum In the stanza 'library' In the package 'base-4.19.2.0' + Note: This version of base is not reinstallable + Suggestion: Bump upper bounds on base to allow a reinstallable versionsignificance: significantin the changelog file.