Skip to content

BE-592: HashQL: Remove old eval graph path and core value types#8841

Open
indietyp wants to merge 5 commits into
bm/be-590-hgraph-entity-query-request-refactorfrom
bm/be-592-hashql-remove-old-eval-graph-path-and-core-value-types
Open

BE-592: HashQL: Remove old eval graph path and core value types#8841
indietyp wants to merge 5 commits into
bm/be-590-hgraph-entity-query-request-refactorfrom
bm/be-592-hashql-remove-old-eval-graph-path-and-core-value-types

Conversation

@indietyp

@indietyp indietyp commented Jun 8, 2026

Copy link
Copy Markdown
Member

🌟 What is the purpose of this PR?

Remove the old eval::graph module (read path, filter expressions, convert, sink) and its compiletest suite (eval_graph_read_entity). Add the new mir_interpret compiletest suite. Delete the now-unused composite value types from hashql-core (Dict, List, Struct, Tuple, Opaque, Value, FieldAccessError), keeping only primitive re-exports.

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

indietyp added 2 commits June 8, 2026 12:40
chore: add new dependency

chore: format

feat: error module

feat: introduce hashql_eval interner

chore: checkpoint

feat: checkpoint

feat: checkpoint

chore: remove old value module

feat: checkpoint

feat: checkpoint

feat: checkpoint

feat: checkpoint

feat: checkpoint

chore: checkpoint

feat: move entity query into its own modul

fix: query request

feat: checkpoint (it compiles!)

feat: checkpoint

feat: checkpoint

feat: checkpoint

fix: issue around cached thunking

feat: covariance for opaque inners

fix: cfgattr serde

chore: remove graph module

fix: merge fuckup
@vercel

vercel Bot commented Jun 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hash Error Error Jun 30, 2026 12:50pm
petrinaut Ready Ready Preview, Comment Jun 30, 2026 12:50pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
hashdotdesign-tokens Ignored Ignored Preview Jun 30, 2026 12:50pm

@cursor

cursor Bot commented Jun 8, 2026

Copy link
Copy Markdown

PR Summary

High Risk
Large removal of entity filter compilation and a breaking shrink of hashql-core::value; any remaining callers of composite values or the graph read compiler would fail to build until migrated to the MIR/postgres eval path.

Overview
Removes the legacy graph read evaluation path from hashql-eval: the whole graph module (HIR visitor GraphReadCompiler, filter/filter-expression lowering, entity query path traversal, value-to-Parameter conversion, diagnostics) and its eval/graph/read/entity compiletest suite plus UI fixtures.

hashql-core::value is reduced to primitive re-exports only; composite types (Value, Dict, List, Struct, Tuple, Opaque) and field/index access APIs are deleted.

hashql-eval no longer exposes a graph Cargo feature—hash-graph-api and compiletest depend on default hashql-eval. Graph-store / type-system wiring moves to dev-dependencies for tests; workspace adds futures-lite and sqruff-lib centrally. Tiny #[inline] on AST lowering Default impls.

Reviewed by Cursor Bugbot for commit a09080b. Bugbot is set up for automated code reviews on this repo. Configure here.

indietyp commented Jun 8, 2026

Copy link
Copy Markdown
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the legacy HashQL graph-read evaluation/compiler path (and its UI/compiletest suite) while simplifying hashql-core’s value surface area down to primitive re-exports. This aligns evaluation/testing around the newer MIR interpreter path and eliminates now-dead value/container types.

Changes:

  • Removed hashql-eval’s old graph module (graph read path/filter compiler/sink/convert/error) and the associated eval/graph/read/entity UI tests.
  • Removed composite value types from hashql-core’s value module, keeping only primitive re-exports.
  • Updated compiletest suite registration/dependencies and workspace dependency versions to reflect the removed graph feature path.

Reviewed changes

Copilot reviewed 102 out of 102 changed files in this pull request and generated no comments.

Show a summary per file
File Description
libs/@local/hashql/hir/src/map.rs Adds #[inline] to Default impl.
libs/@local/hashql/hir/src/lower/normalization.rs Adds #[inline] to Default impl.
libs/@local/hashql/hir/src/context.rs Adds #[inline] to Default impls.
libs/@local/hashql/eval/tests/ui/graph/read/entity/.spec.toml Removes old eval graph-read entity suite spec.
libs/@local/hashql/eval/tests/ui/graph/read/entity/arithmetic-comparisons-and.jsonc Removes old UI test input for graph-read filter compilation.
libs/@local/hashql/eval/tests/ui/graph/read/entity/arithmetic-comparisons-and.stdout Removes old UI test output snapshot.
libs/@local/hashql/eval/tests/ui/graph/read/entity/arithmetic-comparisons-or.jsonc Removes old UI test input for graph-read filter compilation.
libs/@local/hashql/eval/tests/ui/graph/read/entity/arithmetic-comparisons-or.stdout Removes old UI test output snapshot.
libs/@local/hashql/eval/tests/ui/graph/read/entity/boolean-literal.jsonc Removes old UI test input for graph-read filter compilation.
libs/@local/hashql/eval/tests/ui/graph/read/entity/boolean-literal.stdout Removes old UI test output snapshot.
libs/@local/hashql/eval/tests/ui/graph/read/entity/call-identity.jsonc Removes old UI test input for graph-read filter compilation.
libs/@local/hashql/eval/tests/ui/graph/read/entity/call-identity.stderr Removes old UI test error snapshot.
libs/@local/hashql/eval/tests/ui/graph/read/entity/complex-object-error.jsonc Removes old UI test input for graph-read filter compilation.
libs/@local/hashql/eval/tests/ui/graph/read/entity/complex-object-error.stderr Removes old UI test error snapshot.
libs/@local/hashql/eval/tests/ui/graph/read/entity/computed-path-indexing-error.jsonc Removes old UI test input for graph-read filter compilation.
libs/@local/hashql/eval/tests/ui/graph/read/entity/computed-path-indexing-error.stderr Removes old UI test error snapshot.
libs/@local/hashql/eval/tests/ui/graph/read/entity/constructor-call-none.jsonc Removes old UI test input for graph-read filter compilation.
libs/@local/hashql/eval/tests/ui/graph/read/entity/constructor-call-none.stdout Removes old UI test output snapshot.
libs/@local/hashql/eval/tests/ui/graph/read/entity/equality-comparison.jsonc Removes old UI test input for graph-read filter compilation.
libs/@local/hashql/eval/tests/ui/graph/read/entity/equality-comparison.stdout Removes old UI test output snapshot.
libs/@local/hashql/eval/tests/ui/graph/read/entity/field-access-struct.jsonc Removes old UI test input for graph-read filter compilation.
libs/@local/hashql/eval/tests/ui/graph/read/entity/field-access-struct.stdout Removes old UI test output snapshot.
libs/@local/hashql/eval/tests/ui/graph/read/entity/field-access-tuple.jsonc Removes old UI test input for graph-read filter compilation.
libs/@local/hashql/eval/tests/ui/graph/read/entity/field-access-tuple.stdout Removes old UI test output snapshot.
libs/@local/hashql/eval/tests/ui/graph/read/entity/field-in-dict-key.jsonc Removes old UI test input for graph-read filter compilation.
libs/@local/hashql/eval/tests/ui/graph/read/entity/field-in-dict-key.stderr Removes old UI test error snapshot.
libs/@local/hashql/eval/tests/ui/graph/read/entity/field-in-dict-value.jsonc Removes old UI test input for graph-read filter compilation.
libs/@local/hashql/eval/tests/ui/graph/read/entity/field-in-dict-value.stderr Removes old UI test error snapshot.
libs/@local/hashql/eval/tests/ui/graph/read/entity/field-in-list.jsonc Removes old UI test input for graph-read filter compilation.
libs/@local/hashql/eval/tests/ui/graph/read/entity/field-in-list.stderr Removes old UI test error snapshot.
libs/@local/hashql/eval/tests/ui/graph/read/entity/field-in-struct-entry.jsonc Removes old UI test input for graph-read filter compilation.
libs/@local/hashql/eval/tests/ui/graph/read/entity/field-in-struct-entry.stderr Removes old UI test error snapshot.
libs/@local/hashql/eval/tests/ui/graph/read/entity/field-in-struct.jsonc Removes old UI test input for graph-read filter compilation.
libs/@local/hashql/eval/tests/ui/graph/read/entity/field-in-struct.stderr Removes old UI test error snapshot.
libs/@local/hashql/eval/tests/ui/graph/read/entity/field-in-tuple.jsonc Removes old UI test input for graph-read filter compilation.
libs/@local/hashql/eval/tests/ui/graph/read/entity/field-in-tuple.stderr Removes old UI test error snapshot.
libs/@local/hashql/eval/tests/ui/graph/read/entity/if-filter-expr.jsonc Removes old UI test input for graph-read filter compilation.
libs/@local/hashql/eval/tests/ui/graph/read/entity/if-filter-expr.stderr Removes old UI test error snapshot.
libs/@local/hashql/eval/tests/ui/graph/read/entity/if-filter.jsonc Removes old UI test input for graph-read filter compilation.
libs/@local/hashql/eval/tests/ui/graph/read/entity/if-filter.stdout Removes old UI test output snapshot.
libs/@local/hashql/eval/tests/ui/graph/read/entity/input-field-access.jsonc Removes old UI test input for graph-read filter compilation.
libs/@local/hashql/eval/tests/ui/graph/read/entity/input-field-access.stdout Removes old UI test output snapshot.
libs/@local/hashql/eval/tests/ui/graph/read/entity/input-index-access.jsonc Removes old UI test input for graph-read filter compilation.
libs/@local/hashql/eval/tests/ui/graph/read/entity/input-index-access.stdout Removes old UI test output snapshot.
libs/@local/hashql/eval/tests/ui/graph/read/entity/input-parameter.jsonc Removes old UI test input for graph-read filter compilation.
libs/@local/hashql/eval/tests/ui/graph/read/entity/input-parameter.stdout Removes old UI test output snapshot.
libs/@local/hashql/eval/tests/ui/graph/read/entity/invalid-field-access-error.jsonc Removes old UI test input for graph-read filter compilation.
libs/@local/hashql/eval/tests/ui/graph/read/entity/invalid-field-access-error.stderr Removes old UI test error snapshot.
libs/@local/hashql/eval/tests/ui/graph/read/entity/invalid-index-access-error.jsonc Removes old UI test input for graph-read filter compilation.
libs/@local/hashql/eval/tests/ui/graph/read/entity/invalid-index-access-error.stderr Removes old UI test error snapshot.
libs/@local/hashql/eval/tests/ui/graph/read/entity/invalid-vertex-query.jsonc Removes old UI test input for graph-read filter compilation.
libs/@local/hashql/eval/tests/ui/graph/read/entity/invalid-vertex-query.stderr Removes old UI test error snapshot.
libs/@local/hashql/eval/tests/ui/graph/read/entity/let-expression.jsonc Removes old UI test input for graph-read filter compilation.
libs/@local/hashql/eval/tests/ui/graph/read/entity/let-expression.stdout Removes old UI test output snapshot.
libs/@local/hashql/eval/tests/ui/graph/read/entity/let-propagation.jsonc Removes old UI test input for graph-read filter compilation.
libs/@local/hashql/eval/tests/ui/graph/read/entity/let-propagation.stdout Removes old UI test output snapshot.
libs/@local/hashql/eval/tests/ui/graph/read/entity/logical-and-or.jsonc Removes old UI test input for graph-read filter compilation.
libs/@local/hashql/eval/tests/ui/graph/read/entity/logical-and-or.stdout Removes old UI test output snapshot.
libs/@local/hashql/eval/tests/ui/graph/read/entity/logical-or-and.jsonc Removes old UI test input for graph-read filter compilation.
libs/@local/hashql/eval/tests/ui/graph/read/entity/logical-or-and.stdout Removes old UI test output snapshot.
libs/@local/hashql/eval/tests/ui/graph/read/entity/nested-binary-operation.jsonc Removes old UI test input for graph-read filter compilation.
libs/@local/hashql/eval/tests/ui/graph/read/entity/nested-binary-operation.stderr Removes old UI test error snapshot.
libs/@local/hashql/eval/tests/ui/graph/read/entity/nested-let-bindings.jsonc Removes old UI test input for graph-read filter compilation.
libs/@local/hashql/eval/tests/ui/graph/read/entity/nested-let-bindings.stdout Removes old UI test output snapshot.
libs/@local/hashql/eval/tests/ui/graph/read/entity/scalar-property-filter.jsonc Removes old UI test input for graph-read filter compilation.
libs/@local/hashql/eval/tests/ui/graph/read/entity/scalar-property-filter.stdout Removes old UI test output snapshot.
libs/@local/hashql/eval/tests/ui/graph/read/entity/top-level-variable.jsonc Removes old UI test input for graph-read filter compilation.
libs/@local/hashql/eval/tests/ui/graph/read/entity/top-level-variable.stdout Removes old UI test output snapshot.
libs/@local/hashql/eval/tests/ui/graph/read/entity/top-type-assertion.jsonc Removes old UI test input for graph-read filter compilation.
libs/@local/hashql/eval/tests/ui/graph/read/entity/top-type-assertion.stdout Removes old UI test output snapshot.
libs/@local/hashql/eval/tests/ui/graph/read/entity/type-assertion-in-comparison.jsonc Removes old UI test input for graph-read filter compilation.
libs/@local/hashql/eval/tests/ui/graph/read/entity/type-assertion-in-comparison.stdout Removes old UI test output snapshot.
libs/@local/hashql/eval/tests/ui/graph/read/entity/unsupported-closure.jsonc Removes old UI test input for graph-read filter compilation.
libs/@local/hashql/eval/tests/ui/graph/read/entity/unsupported-closure.stderr Removes old UI test error snapshot.
libs/@local/hashql/eval/tests/ui/graph/read/entity/unsupported-nested-graph-read.jsonc Removes old UI test input for graph-read filter compilation.
libs/@local/hashql/eval/tests/ui/graph/read/entity/unsupported-nested-graph-read.stderr Removes old UI test error snapshot.
libs/@local/hashql/eval/tests/ui/graph/read/entity/unsupported-type-constructor.jsonc Removes old UI test input for graph-read filter compilation.
libs/@local/hashql/eval/tests/ui/graph/read/entity/unsupported-type-constructor.stderr Removes old UI test error snapshot.
libs/@local/hashql/eval/src/lib.rs Removes graph module export and an unneeded feature gate.
libs/@local/hashql/eval/src/graph/mod.rs Removes legacy graph module root.
libs/@local/hashql/eval/src/graph/error.rs Removes legacy graph diagnostic category wrapper.
libs/@local/hashql/eval/src/graph/read/mod.rs Removes legacy graph-read compiler entrypoint/types.
libs/@local/hashql/eval/src/graph/read/convert.rs Removes legacy value→parameter conversion logic.
libs/@local/hashql/eval/src/graph/read/error.rs Removes legacy graph-read compiler diagnostics definitions.
libs/@local/hashql/eval/src/graph/read/filter.rs Removes legacy filter compilation logic.
libs/@local/hashql/eval/src/graph/read/filter_expr.rs Removes legacy filter-expression lowering logic.
libs/@local/hashql/eval/src/graph/read/path.rs Removes legacy query-path traversal/conversion logic.
libs/@local/hashql/eval/src/graph/read/sink.rs Removes legacy filter sink builder.
libs/@local/hashql/eval/Cargo.toml Drops the old graph feature wiring and updates deps to workspace-managed versions.
libs/@local/hashql/core/src/value/mod.rs Removes composite Value hierarchy exports, keeping only primitives.
libs/@local/hashql/core/src/value/dict.rs Removes legacy persistent dict value type.
libs/@local/hashql/core/src/value/list.rs Removes legacy persistent list value type.
libs/@local/hashql/core/src/value/opaque.rs Removes legacy opaque/nominal value type.
libs/@local/hashql/core/src/value/struct.rs Removes legacy struct value type and access logic.
libs/@local/hashql/core/src/value/tuple.rs Removes legacy tuple value type and access logic.
libs/@local/hashql/compiletest/src/suite/mod.rs Removes old eval graph-read suite registration.
libs/@local/hashql/compiletest/src/suite/eval_graph_read_entity.rs Removes the compiletest suite that exercised legacy graph-read compilation.
libs/@local/hashql/compiletest/Cargo.toml Removes hashql-eval graph feature usage.
libs/@local/hashql/ast/src/lowering/sanitizer.rs Adds #[inline] to Default impl.
libs/@local/hashql/ast/src/lowering/node_renumberer.rs Adds #[inline] to Default impl.
libs/@local/graph/api/Cargo.toml Drops hashql-eval graph feature enablement.
Cargo.toml Adds workspace dependency versions for futures-lite, sqruff-lib, and sqruff-lib-core.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (bm/be-590-hgraph-entity-query-request-refactor@27f6b87). Learn more about missing BASE report.

Additional details and impacted files
@@                                Coverage Diff                                @@
##             bm/be-590-hgraph-entity-query-request-refactor    #8841   +/-   ##
=================================================================================
  Coverage                                                  ?   59.50%           
=================================================================================
  Files                                                     ?     1353           
  Lines                                                     ?   131116           
  Branches                                                  ?     6008           
=================================================================================
  Hits                                                      ?    78019           
  Misses                                                    ?    52177           
  Partials                                                  ?      920           
Flag Coverage Δ
blockprotocol.type-system 40.84% <ø> (?)
local.claude-hooks 0.00% <ø> (?)
rust.error-stack 90.87% <ø> (?)
rust.harpc-net 96.21% <ø> (?)
rust.harpc-types 0.00% <ø> (?)
rust.harpc-wire-protocol 92.23% <ø> (?)
rust.hash-graph-postgres-store 29.38% <ø> (?)
rust.hash-graph-temporal-versioning 47.95% <ø> (?)
rust.hash-graph-validation 83.43% <ø> (?)
rust.hashql-ast 87.23% <ø> (?)
rust.hashql-compiletest 28.40% <ø> (?)
rust.hashql-core 79.41% <ø> (?)
rust.hashql-eval 79.47% <ø> (?)
rust.hashql-hir 89.06% <ø> (?)
rust.hashql-syntax-jexpr 94.04% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq

codspeed-hq Bot commented Jun 8, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 80 untouched benchmarks


Comparing bm/be-592-hashql-remove-old-eval-graph-path-and-core-value-types (a09080b) with main (7f74e1c)1

Open in CodSpeed

Footnotes

  1. No successful run was found on bm/be-590-hgraph-entity-query-request-refactor (27f6b87) during the generation of this report, so main (7f74e1c) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 103 out of 103 changed files in this pull request and generated 1 comment.

Comment thread libs/@local/hashql/eval/Cargo.toml
@indietyp indietyp force-pushed the bm/be-590-hgraph-entity-query-request-refactor branch from 36c00cc to 8a4c804 Compare June 16, 2026 09:00
@indietyp indietyp force-pushed the bm/be-592-hashql-remove-old-eval-graph-path-and-core-value-types branch from d15129c to d357c57 Compare June 16, 2026 09:00
Comment thread libs/@local/hashql/eval/Cargo.toml
Copilot AI review requested due to automatic review settings June 16, 2026 09:08
@github-actions github-actions Bot added the area/deps Relates to third-party dependencies (area) label Jun 16, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Human review recommended

It performs broad removals across multiple crates (including public-facing type/module deletions) that require full CI validation to ensure no downstream breakage.

Copilot's findings
  • Files reviewed: 103/104 changed files
  • Comments generated: 0 new

Note

Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.

@vercel vercel Bot temporarily deployed to Preview – petrinaut June 16, 2026 09:29 Inactive
Copilot AI review requested due to automatic review settings June 19, 2026 08:15
@indietyp indietyp force-pushed the bm/be-592-hashql-remove-old-eval-graph-path-and-core-value-types branch from 887782c to c6d3684 Compare June 19, 2026 08:15
@indietyp indietyp force-pushed the bm/be-590-hgraph-entity-query-request-refactor branch from 8a4c804 to 877c368 Compare June 19, 2026 08:15
Comment thread libs/@local/hashql/core/src/value/mod.rs

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a09080b. Configure here.

}
}
}
pub use self::primitive::{Float, Integer, Primitive, String};

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused rpds dependency remains

Low Severity

This PR removes Dict and List, which were the only in-crate users of rpds, but hashql-core still declares rpds in Cargo.toml. Nothing in the crate references it anymore, so the dependency is dead weight and can confuse future dependency audits.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit a09080b. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/deps Relates to third-party dependencies (area) area/libs Relates to first-party libraries/crates/packages (area) area/tests New or updated tests type/eng > backend Owned by the @backend team

Development

Successfully merging this pull request may close these issues.

2 participants