Use gophercloud/v2 to support OpenStack 2026.1 - #163
Open
elelaysh wants to merge 1 commit into
Open
Conversation
to support OpenStack 2026.1. Fixes hashicorp#162
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The gophercloud dependency has been updated to latest version v2.14.0.
This is necessary to get versioned endpoint discovery (gophercloud/gophercloud#3435), introduced in v2.8.0.
It fixes this error seen when interacting with an OpenStack 2026.1 cloud:
Changes are:
context.Contextto all operations;servers.Create()instep_run_source_server.go.Regarding passing a
context.Context,AccessConfig.Authenticate()has been split out ofAccessConfig.Prepare()to be able to pass the Context fromBuilder.Run()but it could also be using acontext.Background()Cleanupfunctions sometimes need a Context. I've usedcontext.TODO()but it could be changed tocontext.Background()if need be. Maybe storing the context in the state would also be a valid option.Rest of the code has been changed as little as possible and seem to be working well.
One error remains to be fixed: the
StepRunSourceServer.Cleanup()will show an error if the server has already been deleted (byStepDeleteServer). I would like to handle this case by catching the 404 inServer.DeleteServer.This has been proposed as #140 by @nilsherzig.
Resolved Issues
Closes #162
Rollback Plan
If a change needs to be reverted, we will roll out an update to the code within 7 days.
Changes to Security Controls
There are no changes to security controls.