Skip to content

test: coverage for codec/transport/otel/grpc/lease/gc/vm#69

Merged
markovejnovic merged 10 commits into
mainfrom
test/more-cov
Jul 9, 2026
Merged

test: coverage for codec/transport/otel/grpc/lease/gc/vm#69
markovejnovic merged 10 commits into
mainfrom
test/more-cov

Conversation

@markovejnovic

@markovejnovic markovejnovic commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Skip codec.ex in coverage: it is a compile-time macro whose lines run
during mix compile of the generated schemas, never at test runtime, so
its line coverage is structurally 0% independent of behavioral coverage.
Pure code motion (state.config -> config). The Gc GenServer cannot be
started twice (registered name + Horde singleton), which made its
safety-critical delete step untestable; Prune takes the config directly,
mirroring the existing Gc.Sweep pure-core split.
Also pins the dead-handle contract: fork/fast_fork of an unknown VM is
:not_found and is never misrouted into the capacity fallback.
…anner

Final-review polish: extend the codec property generator to exercise
io_engine/partuuid/socket (were never generated), and delete the
pre-existing '## Internals' banner in gc.ex (no-banner rule) while the
file is already open from the Gc.Prune extraction.
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

Test Results

    4 files  ± 0  219 suites  +12   3m 21s ⏱️ + 1m 3s
  634 tests +29  634 ✅ +29    0 💤 ± 0  0 ❌ ±0 
1 069 runs  +58  634 ✅ +29  435 💤 +29  0 ❌ ±0 

Results for commit e0c6058. ± Comparison against base commit 52bd002.

♻️ This comment has been updated with latest results.

blob!/1 and referenced_blob!/1 declared opts \\ [] but every call site
passes an explicit keyword list, so the default is dead code and trips
--warnings-as-errors in CI's coveralls run (which compiles test files;
local mix compile --warnings-as-errors only covers lib/).
@markovejnovic markovejnovic merged commit 894337a into main Jul 9, 2026
7 checks passed
@markovejnovic markovejnovic deleted the test/more-cov branch July 9, 2026 05:00
@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant