chore(fire_vmm): bump vmlinux to release bab2b3a9#63
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Test Results 4 files ±0 190 suites ±0 2m 13s ⏱️ - 2m 2s Results for commit d6cd9fa. ± Comparison against base commit c8333c7. This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Upstream trimmed kernel configs (~480 options dropped per config) for faster Firecracker boot; kernel versions unchanged (5.10.259 / 6.1.176). Manifest vendored verbatim from the release; asset sha256s verified against the release sidecar files.
markovejnovic
force-pushed
the
chore/bump-vmlinux
branch
from
8d93231 to
e843b96
Compare
install_state/2 counted an asset as installed if the file existed, so a manifest bump never invalidated the redist cache: nodes kept booting the previous release's kernels from the same asset paths forever. A cached file now counts as installed only when its SHA-256 matches the manifest; stale files are re-fetched (all stale -> reinstall in place, partially stale -> wipe and reinstall). Found while validating this branch's vmlinux bump: a provisioned host with the old release cached silently "passed" E2E on the old kernels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
54d6c3f8→bab2b3a9(published 2026-07-08).priv/vmlinux/manifest.jsonvendored verbatim from the release; all five asset sha256s verified against the release.sha256sidecar files.fix(fire_vmm): verify cached vmlinux hashes
Validating this bump exposed a cache-invalidation bug:
Provider.install_state/2counted an asset as installed if the file merely existed, so a manifest bump never invalidated the redist cache — provisioned hosts kept booting the previous release's kernels from the same asset paths, silently. A cached file now counts as installed only when its SHA-256 matches the manifest (stale files are re-fetched). Covered by new stale-hashinstall_state/2tests.Test plan
mix checkgate green (format, compile--warnings-as-errors, credo--strict, 367/367 tests, dialyzer 0 errors)fd24f0ce…download):vm_lifecycle_test.exspasses — boot, exec over vsock, dm reclaim, usage flush, 32 sintegrationjob green on the rebased branch (first run pre-rebase hit the known exec-timeout runner flake; rebase ontoc8333c7+ rerun is green)