feat!: mount function for injecting aditional files into the workspace#163
Open
Power-el-Tanke wants to merge 2 commits into
Open
feat!: mount function for injecting aditional files into the workspace#163Power-el-Tanke wants to merge 2 commits into
Power-el-Tanke wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces the mount abstraction for injecting files into the pipeline workspace. This PR modifies the IR by modifying the Step's schema. The
cmdandenvfields are removed, instead, the action is introduced and accepts a field of the type StepAction, which is an union of Command (a structure that carries the 2 mentioned removed fields) and Mount (which has the source and destination paths of a mount).It can be used in 2 ways:
Both source and destination should be relative to the workspace's path. The destination file/directory should exists unless you set the
strictkwarg to False (defaults to True).Tests
Most of the tests (and only the tests) were modified with the help of an LLM to fit with the new schema. All were human reviewed. An integration test was handwritten in crates/hm/tests/local_e2e.rs for the new feature. There is also the crates/hm-dsl-engine/harmont-py/tests/tests_step_mount.py file for the python side.
Minor changes: