0.1c — amico-validate CLI + CI fast-tier schema gate (closes #17)

[Rchari1]

Stacked on #29 (0.1b). Do not merge.

A user-facing validator over the shared @amicode/schema validate() core, plus a CI step that reds the PR on a schema-invalid config — no parallel validation logic.

What's here

• src/cli.ts: amico-validate <file> [--schema <kind>]. File→schema by basename for the fixed-filename artifacts (manifest.toml/result.toml/lab.toml/FINISHED via kindForFilename); --schema override for solvespec/catalog-entry or any non-standard name. Exit 0 valid / 64 invalid-or-usage (Q85). Field-precise stderr (offending key + JSON-pointer path).
• bin amico-validate → dist/amico-validate.js (esbuild, shebang + chmod; ajv bundles).
• test/fixtures/invalid/: one representative malformed file per kind — the shared negative corpus (the 0.1a valid corpus is the shared positive corpus; one corpus, all surfaces).
• test/cli.test.ts (8): valid→0 + invalid→64 across every kind, file-role resolution, FINISHED-by-basename, non-filename-needs---schema, field-precise stderr, usage→64, --help→0.
• ci.yml: fast-tier amico-validate gate over the shipped configs (lab.toml.example + demo manifest/result/FINISHED) after build.

Review

Adversarial code review: no must-fix / should-fix correctness. Verified empirically — every argv/edge path returns the right exit, kindForFilename doesn't misresolve (result.toml.bak → undefined), the CI bash word-split works (local zsh-only quirk), the gate runs after build, shebang + chmod +x present. One optional hardening nit (CI invokes the bundle directly rather than the linked bin) — non-blocking.

Tests

schema 32 / amico-run 47 / extension 63 green; CLI bundle 308kb.

🤖 Generated with Claude Code

[jack-champagne]

CLI's correct and the gate genuinely fails red — I checked the bash -e errexit path, a malformed config (even a middle one) reds the step. Two changes before merge, both small (inline). Plus the manifest.toml refs here must move in lockstep with #28's run.toml rename.

Tests + Phase 1: two test-debt items vs #17 — the invalid-fixture corpus is one-class-per-file with no wrong-type case (only an in-test mutation covers it; AC7 wants the class matrix self-contained), and the linked amico-validate bin is never exercised in CI (inline). The bigger Phase-1 item: this gate validates only static committed artifacts. Phase 1's reference-prompt smoke corpus IS the real emit→validate gate, and this CI step is where it plugs in — wire one real amico-run → emit run-dir → validate lane here (or in #31/#18), not just configs, so the producer seam is actually covered before Phase 1 piles E2E on top. That's also the infra decision: the cloud solve-service (aws-infra) writes this same run-dir contract to S3, so the gate the cloud track inherits should have seen real emitted output, not just fixtures.

Don't overbuild past this — one ci.yml edit + a build-order fix, not more machinery.

[jack-champagne]

[important] the gate covers lab/manifest/result/FINISHED but not solvespec or catalog-entry — AC5 requires the non-filename schemas via --schema, and the DoD is "all five." Both fixtures are committed; add them:

Suggested change

	$V packages/extension/demo/run/FINISHED
	$V packages/extension/demo/run/FINISHED
	$V packages/schema/test/fixtures/valid/solvespec.toml --schema solvespec
	$V packages/schema/test/fixtures/valid/catalog-entry.toml --schema catalog-entry

[Rchari1]

Done — the gate now also validates solvespec + catalog-entry via --schema (the committed valid fixtures), so all five are covered (AC5 / DoD).

[jack-champagne]

[rename] this manifest.toml becomes run.toml when #28 lands — update here in lockstep or the gate validates a filename that no longer exists.

[Rchari1]

Done — renamed to run.toml in lockstep with #28.

[jack-champagne]

[important] this bin doesn't link on a clean install — dist/amico-validate.js is built by esbuild after pnpm install, so install warns Failed to create bin … ENOENT and the amico-validate command is never created. CI misses it because it runs the bundle path directly. For a slice whose deliverable is "ship the CLI," that's the entry point broken. Fix: a prepare script that builds on install, and have CI exercise the linked bin (pnpm exec amico-validate --help) so a broken entry point reds.

[Rchari1]

Fixed in this push — the bin points at a committed launcher (packages/schema/launcher/amico-validate, mirroring amico-run) that exists at install time, so the bin links cleanly (the dist bundle it execs is built by pnpm build). CI now runs pnpm --filter amicode-v2 exec amico-validate --help (the bin links into the dependents, not the root) so a broken entry point reds.

[jack-champagne]

[rename] this manifest.toml (+ the SCHEMAS.manifest key, the schema filename, and the ci.yml gate line) must follow #28's run.toml rename together — miss one and basename resolution silently falls through to "cannot infer."

[Rchari1]

Done — kindForFilename now resolves run.toml→"run", and the SCHEMAS key / schema filename / ci.yml gate / cli.test KINDS all follow #28s rename. Added a self-contained wrong-type fixture so the class matrix no longer leans on an in-test mutation.

[jack-champagne]

Re-reviewed c8f9863a. All three resolved:

• Wrong-type fixture self-contained — result-wrongtype.toml (fidelity="high", a string where a float is required); AC7's class matrix no longer leans on an in-test mutation.
• Linked bin exercised + gating in CI — the fast job runs pnpm --filter amicode-v2 exec amico-validate --help (a broken bin entry reds) and the committed launcher validates all five schemas under bash -e.
• manifest.toml → run.toml in lockstep with #28.

Approving. Retargeting to main + merging behind #29.