HF-85: Implement DCOUNT database function#1652
Draft
marcin-kordas-hoc wants to merge 10 commits intodevelopfrom
Draft
HF-85: Implement DCOUNT database function#1652marcin-kordas-hoc wants to merge 10 commits intodevelopfrom
marcin-kordas-hoc wants to merge 10 commits intodevelopfrom
Conversation
Add idiomatic code examples to React, Angular, Vue, and Svelte integration pages showing HyperFormula initialization and reading calculated values. Each guide uses framework-specific patterns (React hooks, Angular service, Vue ref/markRaw, Svelte reactivity). Closes HF-122.
Add new DatabasePlugin with DCOUNT(database, field, criteria) that counts numeric values in a specified field column for rows matching criteria. Supports field resolution by name (case-insensitive) and 1-based index, OR logic across criteria rows, AND logic within rows, and comparison operators in criteria values. Includes translations for all 17 languages. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Task linked: HF-85 Implement function DCOUNT |
Performance comparison of head (2e2ecec) vs base (357eee3) |
Add three new database functions to DatabasePlugin with i18n translations for all 17 languages. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove unnecessary type assertions in DAVERAGE, DMAX, DMIN methods. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
New DatabasePlugin with shared helpers for the complete D-function family: DCOUNT, DSUM, DAVERAGE, DMAX, DMIN, DGET, DPRODUCT, DCOUNTA, DSTDEV, DSTDEVP, DVAR, DVARP. 169 tests across 12 test suites. All pass. 17 language translations per function. Excel validation: 152/152 PASS (verified in Excel Desktop). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DatabasePluginwithDCOUNT(database, field, criteria)implementationChanges
src/interpreter/plugin/DatabasePlugin.ts(208 lines)src/interpreter/plugin/index.ts(export added)src/i18n/languages/(DCOUNT translations)CHANGELOG.md(unreleased entry)Implementation Details
resolveFieldIndex(),buildDatabaseCriteria(),rowMatchesCriteria()Math.trunc()CriterionBuilder.fromCellValue()isExtendedNumber()valuesExcel Validation
Tests
hyperformula-tests(matching branch)Review Notes
Linked