Modernize to Swift 5.9+, replace Travis CI with GitHub Actions#14
Open
haaakon wants to merge 1 commit into
Open
Modernize to Swift 5.9+, replace Travis CI with GitHub Actions#14haaakon wants to merge 1 commit into
haaakon wants to merge 1 commit into
Conversation
- Replace deprecated NSNotification.Name.UIKeyboardWillShow/WillHide with UIResponder.keyboardWillShowNotification/keyboardWillHideNotification - Replace deprecated UIKeyboardAnimationDurationUserInfoKey / UIKeyboardFrameEndUserInfoKey with UIResponder.* equivalents - Replace UIViewAnimationOptions with UIView.AnimationOptions - Replace UIEdgeInsetsMake() with UIEdgeInsets(top:left:bottom:right:) - Use guard-let for safer userInfo unwrapping - Use trailing closure syntax for UIView.animate - Use .zero for clearing insets - Add .github/workflows/ci.yml for GitHub Actions CI - Replace Travis CI badge in README with GitHub Actions badge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/ci.ymlthat builds the project on every push and pull request usingmacos-latestUIViewController+Keyboard.swiftto Swift 5.9+:NSNotification.Name.UIKeyboardWillShow/WillHide→UIResponder.keyboardWillShowNotification/keyboardWillHideNotificationUIKeyboardAnimationDurationUserInfoKey/UIKeyboardFrameEndUserInfoKey→UIResponder.*equivalentsUIViewAnimationOptions→UIView.AnimationOptionsUIEdgeInsetsMake()→UIEdgeInsets(top:left:bottom:right:)/.zeroguard letunwrapping of notificationuserInfoinstead of force-castUIView.animateTest plan