fix(state): isApiReady state update race condition - #421
Open
damian-rodriguez-imi wants to merge 1 commit into
Open
fix(state): isApiReady state update race condition#421damian-rodriguez-imi wants to merge 1 commit into
damian-rodriguez-imi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This fix addressed some edge cases where integrators' React implementation might defer committing the
isApiReadystate update. Since the existing hCaptcha's rendering logic was passed as asetStatecallback, delaying the commit also delayed hCaptcha rendering and theonLoadcallback.By using
flushSyncwe force React to commit the state update synchronously, preventing present React scheduling or batching in the integrator from deferring it. The rendering logic then runs immediately afterflushSyncpreserving this way the original order: commitisApiReady, render hCaptcha then callonLoad.References:
https://react.dev/reference/react-dom/flushSync