Wingspan/grpc js 1.14.4 - #3075
Closed
ws-gregm wants to merge 25 commits into
Closed
Conversation
grpc-js(-xds): Bump to 1.14.0 and update README
grpc-js: Re-add a couple of accidentally removed HTTP/2 session settings
…port Backport "Fix server keep alive timeout not properly destroying connections" to 1.14.x
Backport "Send halfClose immediately after messages to prevent late halfClose issues with Envoy" to 1.14.x
grpc-js-xds: Update RBAC code to handle Node type change, pin @types/node (1.14.x)
Fix server crash when handling invalid requests (1.14.x)
Fix crashes when receiving malformed compressed data (1.14.x)
grpc-js: Bump version to 1.14.4
A graceful GOAWAY leaves the keepalive timer running on both the client transport and the server session. The next PING that fails or times out calls the disconnect path, which destroys in-flight RPCs that the GOAWAY had deliberately allowed to finish draining. Client (transport.ts): mark the transport as draining when the session emits goaway, clear any pending keepalive timeout, refuse to start new pings while draining, and ignore the completion callback of a ping that was already in flight when the GOAWAY arrived. The socket close/error handlers still report genuine disconnects, and call deadlines still bound hung calls. Server (server.ts): begin draining a session before any locally initiated close (closeSession, max connection age) and when the peer sends GOAWAY, so the keepalive machinery cannot destroy a session that is intentionally winding down with calls still active. See #3068 for reproductions of both the timer-driven failure and the ping-already-in-flight race. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Rename the grpc-js package to @wingspanhq/grpc-js at 1.14.4-wingspan.1, add the publish workflow and tsconfig.publish.json (src-only compile of the published build/src tree), and document the fork's purpose, build recipe, upstream-rebase procedure, and exit criteria in FORK.md. The copied ORCA protos and the build output stay untracked; copy-protos and tsc regenerate them at publish time. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.