Fix stack buffer overflows in ngc_flowctrl.c#989
Closed
94xhn wants to merge 1 commit into
Closed
Conversation
Signed-off-by: yi chen <94xhn1@gmail.com>
Contributor
|
Instead of failing long names I have instead changed the code to use heap to store them temporarily. Can you please confirm that this fixes your issue in a more graceful way? BTW be aware that the underlying file system may impose its own restrictions on filename lengths... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes two stack buffer overflow vulnerabilities inside
gc_flowctrl.c\ where long user G-code subprogram/macro names retrieved via
gc_string_param_get\ could overflow stack buffers \msg[100]\ and \ ilename[60]. 1. In \onNamedSubError, the error message was formatted using \sprintf(msg, ...)\ where \msg\ is only 100 bytes long, while string parameters can be up to 255 bytes. 2. In the \NGCFlowCtrl_Call\ handler, macro filenames were formatted using \sprintf(filename, ...)\ where \ ilename\ is only 60 bytes long. These are resolved by replacing unsafe \sprintf\ calls with bounds-checked \snprintf.