feat!: add generic e2e support to check-store workflow#279
Open
digitalrisedorset wants to merge 6 commits into
Open
feat!: add generic e2e support to check-store workflow#279digitalrisedorset wants to merge 6 commits into
digitalrisedorset wants to merge 6 commits into
Conversation
damienwebdev
requested changes
May 19, 2026
damienwebdev
requested changes
May 19, 2026
damienwebdev
requested changes
May 21, 2026
| "description": "Github Actions for Magento 2", | ||
| "scripts": { | ||
| "test": "cd supported-version && npm run test && cd - && cd setup-install && npm run test && cd -", | ||
| "test:e2e": "ts-node dev/tests/e2e/**/*.ts", |
| @@ -0,0 +1,33 @@ | |||
| { | |||
Member
There was a problem hiding this comment.
This file likely isn't necessary
| working-directory: ${{ steps.setup-magento.outputs.path }} | ||
| run: | | ||
| npm ci | ||
| npm run test:e2e No newline at end of file |
Member
There was a problem hiding this comment.
Does test:e2e exist as a script in every Magento store with a dev/tests/e2e folder?
Author
There was a problem hiding this comment.
This command exists so that we can executes the elgentos playwright test suite under dev/tests/e2e. I assume you are clear with this. I added it in package.json for CI to be able to trigger this test suite. Somehow, I unclear how e2e gets trigger without the command-line. I will follow your lead and will remove the code as per your suggestions, thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
check-store.yamlcurrently supports:There is currently no generic mechanism for executing optional store-defined E2E test suites within the reusable workflow.
Fixes: N/A
What is the new behavior?
Adds optional
e2e-testsupport tocheck-store.yaml.The workflow now:
package.jsonexistsnpm run test:e2eThis keeps E2E implementation details owned by the consuming store while allowing Mage-OS CI orchestration to execute generic Node-based E2E suites.
A minimal TypeScript-based E2E fixture was also added to validate the orchestration flow.
Does this PR introduce a breaking change?
Other information
This intentionally keeps the E2E contract lightweight and framework-agnostic for now.
The workflow orchestrates execution but does not enforce:
This allows consuming stores to define their own E2E implementation details while reusing the existing Mage-OS orchestration and Magento service bootstrapping.