refactor(Table): use new builder methods to register nodes - #1204
Merged
Conversation
Reviewer's GuideRefactors the markdown table extension to use new ExtensionAuto builder modules for schema, parser, and serializer registrations, and updates imports to the new core/table-utils alias paths. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
d3m1d0v
marked this pull request as ready for review
August 4, 2026 14:54
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new TableSchemaSpecs/TableParserSpecs/TableSerializerSpecs helpers repeat the same add*Spec calls for each TableNode; consider iterating over a shared list of node keys to reduce duplication and make it easier to add new table node types in the future.
- The import path for TableRole changed from a relative path to 'src/table-utils'; confirm this aligns with your project’s alias conventions (similar to '#core') so the module resolves consistently across build and test environments.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new TableSchemaSpecs/TableParserSpecs/TableSerializerSpecs helpers repeat the same add*Spec calls for each TableNode; consider iterating over a shared list of node keys to reduce duplication and make it easier to add new table node types in the future.
- The import path for TableRole changed from a relative path to 'src/table-utils'; confirm this aligns with your project’s alias conventions (similar to '#core') so the module resolves consistently across build and test environments.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
makhnatkin
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Refactor markdown table extension to register schema, parser, and serializer via dedicated builder helper specs.
Enhancements: