Skip to content

refactor(Table): use new builder methods to register nodes - #1204

Merged
d3m1d0v merged 1 commit into
mainfrom
refactor-table
Aug 5, 2026
Merged

refactor(Table): use new builder methods to register nodes#1204
d3m1d0v merged 1 commit into
mainfrom
refactor-table

Conversation

@d3m1d0v

@d3m1d0v d3m1d0v commented Aug 4, 2026

Copy link
Copy Markdown
Member

Summary by Sourcery

Refactor markdown table extension to register schema, parser, and serializer via dedicated builder helper specs.

Enhancements:

  • Introduce TableSchemaSpecs, TableParserSpecs, and TableSerializerSpecs helpers for table node registration.
  • Update TableSpecs to use chained builder.use(...) calls for table-related specs.
  • Align imports to use the new core and table-utils module paths.

@sourcery-ai

sourcery-ai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Reviewer's Guide

Refactors the markdown table extension to use new ExtensionAuto builder modules for schema, parser, and serializer registrations, and updates imports to the new core/table-utils alias paths.

File-Level Changes

Change Details Files
Refactor TableSpecs to compose separate schema, parser, and serializer ExtensionAuto modules using the new builder API.
  • Replace direct builder.addNode registrations with builder.use calls to TableSchemaSpecs, TableParserSpecs, and TableSerializerSpecs.
  • Update imports in TableSpecs to reference the new spec modules instead of raw schema/parser/serializer maps.
  • Keep TableNode re-export unchanged for external consumers.
packages/editor/src/extensions/markdown/Table/TableSpecs/index.ts
Extract node schema registrations into a dedicated TableSchemaSpecs ExtensionAuto module.
  • Convert exported schemaSpecs map into an internal constant and add a new TableSchemaSpecs ExtensionAuto function.
  • Register each table-related node spec via builder.addNodeSpec for Table, Head, Body, Row, HeaderCell, and DataCell.
  • Update imports to use the new #core alias for ExtensionAuto and change TableRole import to the new table-utils path.
packages/editor/src/extensions/markdown/Table/TableSpecs/schema.ts
Extract markdown parser token registrations into a dedicated TableParserSpecs ExtensionAuto module.
  • Convert exported parserTokens map into an internal constant and add a new TableParserSpecs ExtensionAuto function.
  • Use builder.addMarkdownTokenParserSpec for each table node (Table, Head, Body, Row, HeaderCell, DataCell).
  • Update imports to use the new #core alias for ExtensionAuto and ParserToken.
packages/editor/src/extensions/markdown/Table/TableSpecs/parser.ts
Extract serializer token registrations into a dedicated TableSerializerSpecs ExtensionAuto module.
  • Convert exported serializerTokens map into an internal constant and add a new TableSerializerSpecs ExtensionAuto function.
  • Register node serializer specs via builder.addNodeSerializerSpec for each table node (Table, Head, Body, Row, HeaderCell, DataCell).
  • Update imports to use the new #core alias for ExtensionAuto and SerializerNodeToken.
packages/editor/src/extensions/markdown/Table/TableSpecs/serializer.ts

Possibly linked issues

  • #[WIP] Major 16 manifest: The PR updates Table to new builder APIs, directly contributing to the manifest’s major-16 core refactor tasks.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@gravity-ui

gravity-ui Bot commented Aug 4, 2026

Copy link
Copy Markdown

Storybook Deployed

@gravity-ui

gravity-ui Bot commented Aug 4, 2026

Copy link
Copy Markdown

🎭 Playwright Report

@d3m1d0v
d3m1d0v marked this pull request as ready for review August 4, 2026 14:54
@d3m1d0v
d3m1d0v requested a review from makhnatkin as a code owner August 4, 2026 14:54

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The new TableSchemaSpecs/TableParserSpecs/TableSerializerSpecs helpers repeat the same add*Spec calls for each TableNode; consider iterating over a shared list of node keys to reduce duplication and make it easier to add new table node types in the future.
  • The import path for TableRole changed from a relative path to 'src/table-utils'; confirm this aligns with your project’s alias conventions (similar to '#core') so the module resolves consistently across build and test environments.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The new TableSchemaSpecs/TableParserSpecs/TableSerializerSpecs helpers repeat the same add*Spec calls for each TableNode; consider iterating over a shared list of node keys to reduce duplication and make it easier to add new table node types in the future.
- The import path for TableRole changed from a relative path to 'src/table-utils'; confirm this aligns with your project’s alias conventions (similar to '#core') so the module resolves consistently across build and test environments.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@d3m1d0v
d3m1d0v merged commit be939bd into main Aug 5, 2026
8 of 9 checks passed
@d3m1d0v
d3m1d0v deleted the refactor-table branch August 5, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants