Skip to content

refactor(HorizontalRule): use new builder methods to register nodes - #1203

Open
d3m1d0v wants to merge 1 commit into
mainfrom
refactor-horizontalrule
Open

refactor(HorizontalRule): use new builder methods to register nodes#1203
d3m1d0v wants to merge 1 commit into
mainfrom
refactor-horizontalrule

Conversation

@d3m1d0v

@d3m1d0v d3m1d0v commented Aug 4, 2026

Copy link
Copy Markdown
Member

Summary by Sourcery

Refactor horizontal rule markdown node to use the new builder APIs for node specs, markdown token parsing, and node serialization.

Enhancements:

  • Switch horizontal rule extension to use addNodeSpec, addMarkdownTokenParserSpec, and addNodeSerializerSpec APIs.
  • Update imports to use new core and schema module paths.

@sourcery-ai

sourcery-ai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refactors the HorizontalRule markdown extension to use the new builder APIs for node specs, markdown token parsing, and node serialization, and updates imports to the new module paths.

File-Level Changes

Change Details Files
Refactor HorizontalRule extension to use new builder methods for node definition, markdown parsing, and serialization.
  • Replace addNode usage with a fluent chain of addNodeSpec, addMarkdownTokenParserSpec, and addNodeSerializerSpec on the builder
  • Split the previous combined node spec/fromMd/toMd config into distinct builder registrations for the ProseMirror node spec, markdown token parser spec, and node serializer callback
  • Preserve existing behavior for attrs, DOM parsing/rendering, markdown token name, and markup handling while restructuring the configuration
packages/editor/src/extensions/markdown/HorizontalRule/HorizontalRuleSpecs/index.ts
Update imports to new core and schema utility module paths.
  • Change ExtensionAuto import to use the '#core' alias instead of a relative path
  • Change nodeTypeFactory import to use 'src/utils/schema' instead of a deeply nested relative path
packages/editor/src/extensions/markdown/HorizontalRule/HorizontalRuleSpecs/index.ts

Possibly linked issues

  • #WIP-major-16-manifest: PR implements the issue’s requirement to stop using addNode by switching HorizontalRule to new builder methods.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@gravity-ui

gravity-ui Bot commented Aug 4, 2026

Copy link
Copy Markdown

Storybook Deployed

@gravity-ui

gravity-ui Bot commented Aug 4, 2026

Copy link
Copy Markdown

🎭 Playwright Report

@d3m1d0v
d3m1d0v marked this pull request as ready for review August 4, 2026 14:37
@d3m1d0v
d3m1d0v requested a review from makhnatkin as a code owner August 4, 2026 14:37

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant