Skip to content

refactor(Bold): use new builder methods to register marks - #1200

Merged
d3m1d0v merged 1 commit into
mainfrom
refactor-bold
Aug 5, 2026
Merged

refactor(Bold): use new builder methods to register marks#1200
d3m1d0v merged 1 commit into
mainfrom
refactor-bold

Conversation

@d3m1d0v

@d3m1d0v d3m1d0v commented Aug 4, 2026

Copy link
Copy Markdown
Member

Summary by Sourcery

Enhancements:

  • Split bold mark registration into separate mark spec, markdown token parser spec, and mark serializer spec using the updated builder API.

@sourcery-ai

sourcery-ai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refactors the Bold markdown extension to use the new builder APIs, splitting the mark definition into separate mark spec, markdown token parser spec, and mark serializer spec registrations while preserving existing behavior.

File-Level Changes

Change Details Files
Refactor Bold extension registration to use dedicated builder methods for mark spec, markdown token parser spec, and mark serializer spec.
  • Replace single addMark registration with chained calls to addMarkSpec, addMarkdownTokenParserSpec, and addMarkSerializerSpec.
  • Keep the ProseMirror mark spec (attrs, parseDOM, toDOM) intact but register it via addMarkSpec.
  • Extract the markdown token parser configuration into addMarkdownTokenParserSpec preserving name, type, and getAttrs logic.
  • Move the markdown serialization configuration (open/close markup and flags) into addMarkSerializerSpec with the same options.
packages/editor/src/extensions/markdown/Bold/BoldSpecs/index.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@gravity-ui

gravity-ui Bot commented Aug 4, 2026

Copy link
Copy Markdown

Storybook Deployed

@gravity-ui

gravity-ui Bot commented Aug 4, 2026

Copy link
Copy Markdown

🎭 Playwright Report

@d3m1d0v
d3m1d0v marked this pull request as ready for review August 4, 2026 14:35
@d3m1d0v
d3m1d0v requested a review from makhnatkin as a code owner August 4, 2026 14:35

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@d3m1d0v
d3m1d0v merged commit d8e4164 into main Aug 5, 2026
8 of 9 checks passed
@d3m1d0v
d3m1d0v deleted the refactor-bold branch August 5, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants