Skip to content

refactor(Blockquote): use new builder methods to register nodes - #1199

Open
d3m1d0v wants to merge 1 commit into
mainfrom
refactor-blockquote
Open

refactor(Blockquote): use new builder methods to register nodes#1199
d3m1d0v wants to merge 1 commit into
mainfrom
refactor-blockquote

Conversation

@d3m1d0v

@d3m1d0v d3m1d0v commented Aug 4, 2026

Copy link
Copy Markdown
Member

Summary by Sourcery

Refactor the Blockquote markdown extension to use the new builder APIs for node specs, markdown token parsing, and node serialization.

Enhancements:

  • Update Blockquote extension to register its node, markdown token parser, and serializer via the new builder methods.
  • Adjust Blockquote-related imports to use the updated core and schema module paths.

@sourcery-ai

sourcery-ai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refactors the Blockquote markdown extension to use the new builder APIs for node specs, markdown token parsing, and node serialization, while updating imports to new core and schema paths.

File-Level Changes

Change Details Files
Switch Blockquote extension to the new builder APIs for node spec, markdown token parser, and serializer registration.
  • Replace builder.addNode usage with chained builder.addNodeSpec, addMarkdownTokenParserSpec, and addNodeSerializerSpec calls.
  • Define the blockquote node spec via addNodeSpec with content, group, defining, parseDOM, selectable, and selectAll options.
  • Register a markdown token parser spec for blockquote using addMarkdownTokenParserSpec with name and type fields.
  • Register the blockquote node serializer via addNodeSerializerSpec to wrap content in blockquote markup using state.wrapBlock.
packages/editor/src/extensions/markdown/Blockquote/BlockquoteSpecs/index.ts
Update Blockquote extension imports to align with new core and schema module paths.
  • Change ExtensionAuto import source from a relative core path to the '#core' alias.
  • Change nodeTypeFactory import source from a relative utils/schema path to 'src/utils/schema'.
packages/editor/src/extensions/markdown/Blockquote/BlockquoteSpecs/index.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@gravity-ui

gravity-ui Bot commented Aug 4, 2026

Copy link
Copy Markdown

Storybook Deployed

@gravity-ui

gravity-ui Bot commented Aug 4, 2026

Copy link
Copy Markdown

🎭 Playwright Report

@d3m1d0v
d3m1d0v marked this pull request as ready for review August 4, 2026 14:36
@d3m1d0v
d3m1d0v requested a review from makhnatkin as a code owner August 4, 2026 14:36

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant