refactor(Breaks): use new builder methods to register nodes - #1198
Merged
Conversation
Reviewer's GuideRefactors hard and soft break extension configuration to use new builder methods for node specs, markdown token parsing, and node serialization, and updates imports to the new path aliases. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
d3m1d0v
force-pushed
the
refactor-breaks
branch
from
August 4, 2026 14:55
9d8fb80 to
c92ee59
Compare
d3m1d0v
marked this pull request as ready for review
August 4, 2026 15:05
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The hard and soft break node specs share identical configuration (inline/group/marks/parseDOM/toDOM); consider extracting a small helper to avoid duplication and make future changes easier.
- Now that builder methods are chained, double-check that the expected registration order (spec → markdown parser → serializer) matches the builder API’s assumptions, or document any required ordering to prevent subtle misuse in other extensions.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The hard and soft break node specs share identical configuration (inline/group/marks/parseDOM/toDOM); consider extracting a small helper to avoid duplication and make future changes easier.
- Now that builder methods are chained, double-check that the expected registration order (spec → markdown parser → serializer) matches the builder API’s assumptions, or document any required ordering to prevent subtle misuse in other extensions.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
makhnatkin
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Refactor markdown break node registration to use the new builder APIs while preserving existing behavior.
Enhancements: