fix(gfql): preserve boolean sum zero on polars gpu - #2002
Merged
Conversation
lmeyerov
marked this pull request as ready for review
August 21, 2026 02:33
lmeyerov
added a commit
that referenced
this pull request
Aug 21, 2026
lmeyerov
added a commit
that referenced
this pull request
Aug 21, 2026
lmeyerov
added a commit
that referenced
this pull request
Aug 21, 2026
lmeyerov
added a commit
that referenced
this pull request
Aug 21, 2026
This was referenced Aug 21, 2026
Merged
lmeyerov
added a commit
that referenced
this pull request
Aug 21, 2026
Contributor
Author
|
Stacked incorrectly |
lmeyerov
changed the base branch from
master
to
fix/gfql-1996-binding-seed-identity
August 21, 2026 20:12
lmeyerov
commented
Aug 21, 2026
lmeyerov
force-pushed
the
fix/gfql-1996-binding-seed-identity
branch
from
August 27, 2026 09:52
01b0c66 to
a888c33
Compare
lmeyerov
force-pushed
the
fix/gfql-1997-polars-gpu-bool-sum
branch
from
August 27, 2026 10:31
e216bcd to
712e2d1
Compare
Contributor
Author
|
Resolved on exact head |
lmeyerov
force-pushed
the
fix/gfql-1997-polars-gpu-bool-sum
branch
from
August 28, 2026 13:55
712e2d1 to
d357373
Compare
lmeyerov
changed the base branch from
fix/gfql-1996-binding-seed-identity
to
master
August 28, 2026 13:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sumresult to the GFQL/Cypher zero contract.sumbefore the existing Int64 result cast.[Development]inCHANGELOG.md.Final linear state
d3573735040d7f65d00a24f2e08fa5b8a9d83e77masterat merged fix(gfql): treat binding seed ids as identities #2001 commitd627fac2e7e55168f0ba43b8b1f4e3311b4e2f52The four previously reviewed code/test patches are range-diff exact after the final rebase. The fifth commit adds only the requested changelog entry.
Semantics boundary
polars_conform_agg_dtype()fills null only when both conditions hold: the aggregate issumand the input dtype is Boolean.The focused test pins:
sumnull → Int64 zero.countnull → Int64 null.sumnull → unchanged null.Validation
./bin/lint.sh: clean, including type-hygiene, comment-density, and import guards../bin/typecheck.sh: mypy 2.3.1, 336 source files, zero issues.Review resolution
Landing
Review the master-relative range
d627fac2e...d35737350.After this exact-head CI generation is green, the authorized landing method is GitHub Create a merge commit with admin override. Retain the source branch.