Skip to content

Keep SortedSet discard quiet after key changes #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CodingFeng101 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Keep SortedSet discard quiet after key changes #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/sortedcontainers/sortedset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,11 @@ def discard(self, value):
_set = self._set
if value in _set:
_set.remove(value)
self._list.remove(value)
try:
self._list.remove(value)
except ValueError:
self._list.clear()
self._list.update(_set)

_discard = discard

Expand Down
10 changes: 10 additions & 0 deletions tests/test_coverage_sortedset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,16 @@ def test_discard():
assert len(temp) == 97


def test_discard_with_changed_key():
keys = {value: value for value in range(5)}
temp = SortedSet(range(5), key=keys.__getitem__)
value = temp[-1]
keys[value] = -1
temp.discard(value)
temp._check()
assert value not in temp


def test_index():
temp = SortedSet(range(100))
temp._reset(7)
Expand Down