fix(admin): resolve partial-view name collision in Order AddressEdit - #798
Merged
Merged
Conversation
Admin/Order/AddressEdit threw InvalidOperationException: the model item passed into the ViewDataDictionary is of type OrderAddressModel, but the ViewDataDictionary instance requires AddressModel. Root cause: the shared partial "Partials/CreateOrUpdateAddress" used by Grand.Web.AdminShared's Order/AddressEdit.cshtml has the same relative name as the storefront's own Views/Shared/Partials/CreateOrUpdateAddress.cshtml (@model AddressModel) in Grand.Web. In the combined host, ASP.NET Core's default area view location fallback "/Views/Shared/{0}.cshtml" is checked before the project's own custom AdminShared fallback location, so the storefront's partial (bound to AddressModel) was resolved instead of the intended AdminShared Order partial (bound to OrderAddressModel), causing the model type mismatch. Fix: rename the AdminShared Order partial to Partials/OrderCreateOrUpdateAddress, which no longer collides with any storefront view name, and update the one reference to it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QArzgnTu2jhTmm4LiMjuNF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: bugfix
Issue
Editing a billing or shipping address on an order in the Admin panel (
Admin/Order/AddressEdit?addressId=...&orderId=...&BillingAddress=True) threw:InvalidOperationException: The model item passed into the ViewDataDictionary is of type 'Grand.Web.AdminShared.Models.Orders.OrderAddressModel', but this ViewDataDictionary instance requires a model item of type 'Grand.Web.Models.Common.AddressModel'.Root cause:
src/Web/Grand.Web.AdminShared/Views/AdminShared/Order/AddressEdit.cshtmlrendered a partial namedPartials/CreateOrUpdateAddress. That relative name collided with the storefront's ownsrc/Web/Grand.Web/Views/Shared/Partials/CreateOrUpdateAddress.cshtml(@model AddressModel). In the combined Grand.Web host, ASP.NET Core's default area view-location fallback/Views/Shared/{0}.cshtmlis checked before the repo's customViewLocationExpanderfallback onto/Views/AdminShared/{1}/{0}.cshtml, so the storefront'sAddressModel-based partial was resolved instead of the intendedOrderAddressModel-based AdminShared partial, causing the model-type mismatch.Reproduce: open any order in Admin, click edit on the billing or shipping address.
Solution
Renamed the colliding AdminShared partial from
Partials/CreateOrUpdateAddresstoPartials/OrderCreateOrUpdateAddress(no other file in the repo uses that exact relative partial path), and updated the single reference to it inAddressEdit.cshtml. This is a pure rename with no behavior change to the partial's content, so Admin, Vendor, and Store hosts (which all share this AdminShared controller/view) are fixed identically.Breaking changes
None. This is an internal view-file rename; no public contract, model, or route changed.
Testing