Skip to content

refactor: use += for period, samples, and count accumulation#302

Closed
maayanmatsliah-tech wants to merge 1 commit into
graalvm:masterfrom
maayanmatsliah-tech:master
Closed

refactor: use += for period, samples, and count accumulation#302
maayanmatsliah-tech wants to merge 1 commit into
graalvm:masterfrom
maayanmatsliah-tech:master

Conversation

@maayanmatsliah-tech
Copy link
Copy Markdown

Wow, this is a cool repo! Made a small cleanup in mx_proftool.py — replaced manual addition assignments with += in merge_perf_events and get_top_methods. No behavior change. Hope this helps!

@oracle-contributor-agreement
Copy link
Copy Markdown

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement Bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label May 4, 2026
@maayanmatsliah-tech
Copy link
Copy Markdown
Author

Hi! I've signed the Oracle CLA. Could you please review when you get a chance?

@dougxc
Copy link
Copy Markdown
Member

dougxc commented May 13, 2026

hi @maayanmatsliah-tech, thanks for the contribution!

We generally try to keep the git history focused on functional changes or significant refactors. This change is purely stylistic and doesn't impact performance or readability, so we’re going to pass on it to keep the noise in the logs down.

@dougxc dougxc closed this May 13, 2026
@maayanmatsliah-tech
Copy link
Copy Markdown
Author

Got it. Thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Required At least one contributor does not have an approved Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants