Check clearing of 3d textures when rendering to a slice#4625
Merged
greggman merged 2 commits intogpuweb:mainfrom Apr 20, 2026
Merged
Check clearing of 3d textures when rendering to a slice#4625greggman merged 2 commits intogpuweb:mainfrom
greggman merged 2 commits intogpuweb:mainfrom
Conversation
|
Results for build job (at 1451f21): -webgpu:api,operation,rendering,3d_texture_slices:one_color_attachment,mip_levels:* - 6 cases, 6 subcases (~1/case)
-webgpu:api,operation,rendering,3d_texture_slices:multiple_color_attachments,same_mip_level:* - 2 cases, 8 subcases (~4/case)
-webgpu:api,operation,rendering,3d_texture_slices:multiple_color_attachments,same_slice_with_diff_mip_levels:* - 2 cases, 2 subcases (~1/case)
+webgpu:api,operation,rendering,3d_texture_slices:one_color_attachment,mip_levels:* - 234 cases, 234 subcases (~1/case)
+webgpu:api,operation,rendering,3d_texture_slices:multiple_color_attachments,same_mip_level:* - 78 cases, 312 subcases (~4/case)
+webgpu:api,operation,rendering,3d_texture_slices:multiple_color_attachments,same_slice_with_diff_mip_levels:* - 78 cases, 78 subcases (~1/case)
-TOTAL: 280796 cases, 2322135 subcases
+TOTAL: 281176 cases, 2322743 subcases |
kainino0x
approved these changes
Apr 18, 2026
Collaborator
kainino0x
left a comment
There was a problem hiding this comment.
apologies for delay, I got a huge amount of reviews at once on wednesday and this one was a bit hard to read (I still didn't read it super closely but I found the core logic and it looks good)
There was an issue in some browsers where, when rendering to a slice of a 3d texture, they'd mark the entire texture as initialized even though only the individual slice was initialized. Updated the tests so they check the entire texture. Also updated them to try every format.
b21267c to
1451f21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an issue in some browsers where, when rendering to a slice of a 3d texture, they'd mark the entire texture as initialized even though only the individual slice was initialized.
Updated the tests so they check the entire texture. Also updated them to try every format.
Several formats are failing in Chrome even with the latest updated to address this.
Issue: #
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.