Skip to content

Show LOC on concluded rankings#249

Merged
msaroufim merged 1 commit into
mainfrom
simplify-ranking-loc
Jul 5, 2026
Merged

Show LOC on concluded rankings#249
msaroufim merged 1 commit into
mainfrom
simplify-ranking-loc

Conversation

@msaroufim

@msaroufim msaroufim commented Jul 5, 2026

Copy link
Copy Markdown
Member

Summary

  • Move LOC display to the main ranking rows for concluded competitions.
  • Keep line_count on /api/leaderboard ranking rows instead of /api/codes/code drawer metadata.
  • Remove the extra code-drawer LOC path and tests introduced in Show LOC for public solutions #248.
  • Remove the old leaderboard 598 code-view block so concluded leaderboards are handled consistently.

Validation

  • git diff --check
  • .venv/bin/ruff check kernelboard/api/leaderboard.py kernelboard/api/submission.py tests/api/test_submission_api.py
  • npm run lint
  • npm run build

Notes

  • Backend route pytest still requires Docker for the Postgres/Redis fixtures; Docker is not running in this local environment.

@msaroufim msaroufim force-pushed the simplify-ranking-loc branch from 192a1e7 to e1184b3 Compare July 5, 2026 02:50
@msaroufim msaroufim merged commit b3c85ba into main Jul 5, 2026
1 check passed
msaroufim added a commit that referenced this pull request Jul 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant