Add SecureCookie.Err for surfacing deferred configuration errors#92
Open
c-tonneslan wants to merge 1 commit into
Open
Add SecureCookie.Err for surfacing deferred configuration errors#92c-tonneslan wants to merge 1 commit into
c-tonneslan wants to merge 1 commit into
Conversation
New stores configuration errors (missing hash key, bad block key, etc.) on the returned SecureCookie and only returns them later from Encode or Decode. Callers that want to fail fast had no way to read that state. Add an Err accessor that returns the stored error, leaving the existing Encode/Decode behavior unchanged. Closes gorilla#89 Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #89.
Newstores configuration errors (no hash key, bad block key, etc.) on the returnedSecureCookiebut only surfaces them whenEncode/Decodeis later called. There's no way to fail fast at setup time without trying to encode a dummy value.Add a tiny
Err()accessor that returns the stored error.EncodeandDecodeare unchanged; this is purely additive.Closes #89