chore: Fix build pipeline and routing for React samples. - #1623
Open
willum070 wants to merge 2 commits into
Open
chore: Fix build pipeline and routing for React samples.#1623willum070 wants to merge 2 commits into
willum070 wants to merge 2 commits into
Conversation
Change-Id: I75a1735bea837351371a345feceab13e42f00f81
Change-Id: I7223e4daf8ba2874ebc23470773eed94e5adcf95
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes a bug in our sample build pipeline where React/Vite samples were incorrectly being routed through the vanilla
docs.shscript, causing theirsrc/directories to be destructively flattened and breaking DevSite macro expectations.Key Changes:
samples/dist.sh:samples/build-single.sh:src/app.tsx|jsx|js). React samples are now properly routed toreact-docs.sh.rm -rf diststep prior totscexecution. This ensures Vite's hashed assets don't perpetually accumulate over successive local builds.samples/react-docs.sh:app.tsxinsidedocs/src/.app.jsandstyle.cssdirectly into thedocs/root exactly where DevSite expects them for live rendering."buildRevision": 1field to thepackage.jsonof all React (rgm-*andreact-ui-kit-*) samples to cleanly force a CI rebuild and output sync without polluting the source files.