Skip to content

fix: validate resource name to prevent path traversal in Documents op… #2338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brodmart wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −0
Open

fix: validate resource name to prevent path traversal in Documents op… #2338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions google/genai/documents.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,13 @@
# limitations under the License.
#


def _validate_resource_name(name: str) -> None:
if '..' in name:
raise ValueError(
f'Invalid resource name {name!r}: must not contain path traversal sequences'
)

# Code generated by the Google Gen AI SDK generator DO NOT EDIT.

from functools import partial
Expand Down Expand Up @@ -156,6 +163,7 @@ def get(
request_dict = _GetDocumentParameters_to_mldev(parameter_model)
request_url_dict = request_dict.get('_url')
if request_url_dict:
_validate_resource_name(request_url_dict.get('name', ''))
path = '{name}'.format_map(request_url_dict)
else:
path = '{name}'
Expand Down Expand Up @@ -233,6 +241,7 @@ def delete(
request_dict = _DeleteDocumentParameters_to_mldev(parameter_model)
request_url_dict = request_dict.get('_url')
if request_url_dict:
_validate_resource_name(request_url_dict.get('name', ''))
path = '{name}'.format_map(request_url_dict)
else:
path = '{name}'
Expand Down Expand Up @@ -384,6 +393,7 @@ async def get(
request_dict = _GetDocumentParameters_to_mldev(parameter_model)
request_url_dict = request_dict.get('_url')
if request_url_dict:
_validate_resource_name(request_url_dict.get('name', ''))
path = '{name}'.format_map(request_url_dict)
else:
path = '{name}'
Expand Down Expand Up @@ -463,6 +473,7 @@ async def delete(
request_dict = _DeleteDocumentParameters_to_mldev(parameter_model)
request_url_dict = request_dict.get('_url')
if request_url_dict:
_validate_resource_name(request_url_dict.get('name', ''))
path = '{name}'.format_map(request_url_dict)
else:
path = '{name}'
Expand Down