fix: Remove the google-cloud-iam dependency from the agent_engines extra. - #7050
Open
copybara-service[bot] wants to merge 1 commit into
Open
fix: Remove the google-cloud-iam dependency from the agent_engines extra.#7050copybara-service[bot] wants to merge 1 commit into
google-cloud-iam dependency from the agent_engines extra.#7050copybara-service[bot] wants to merge 1 commit into
Conversation
…` extra. `Sandboxes.generate_access_token()` was the only thing in the SDK using `google-cloud-iam`, for a single `projects.serviceAccounts.signJwt` call. That call is now made directly against the IAM Credentials REST endpoint using `google-auth`, which is already a core requirement, so `google-cloud-iam` is no longer installed by `pip install google-cloud-aiplatform[agent_engines]`. The method signature, the JWT payload and the returned token are unchanged, and the endpoint is now resolved against the credentials universe domain so it also works outside `googleapis.com`. Note that a failed signing call now raises `requests.exceptions.HTTPError` rather than a `google.api_core.exceptions` type. PiperOrigin-RevId: 959240124
product-auto-label
Bot
added
size: l
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Remove the
google-cloud-iamdependency from theagent_enginesextra.Sandboxes.generate_access_token()was the only thing in the SDK usinggoogle-cloud-iam, for a singleprojects.serviceAccounts.signJwtcall. Thatcall is now made directly against the IAM Credentials REST endpoint using
google-auth, which is already a core requirement, sogoogle-cloud-iamis nolonger installed by
pip install google-cloud-aiplatform[agent_engines].The method signature, the JWT payload and the returned token are unchanged, and
the endpoint is now resolved against the credentials universe domain so it also
works outside
googleapis.com.Note that a failed signing call now raises
requests.exceptions.HTTPErrorrather than a
google.api_core.exceptionstype.