feat(bigtable): populate reasons on why direct access was not accessible#2905
Open
feat(bigtable): populate reasons on why direct access was not accessible#2905
Conversation
product-auto-label
Bot
added
size: l
nimf
approved these changes
Apr 25, 2026
| originalError); | ||
| return; | ||
| } | ||
| // Default fallback if investigation could not determine a specific issue recordAndLog( |
Contributor
There was a problem hiding this comment.
Suggested change
| // Default fallback if investigation could not determine a specific issue recordAndLog( | |
| // Default fallback if investigation could not determine a specific issue |
| if ("Linux".equals(osName)) { | ||
| String productName = getSystemProductName(); | ||
| return productName.contains(GCE_PRODUCTION_NAME_PRIOR_2016) | ||
| || productName.contains(GCE_PRODUCTION_NAME_AFTER_2016); |
Contributor
There was a problem hiding this comment.
I mean, if it doesn't contain "Google" why do we need to check if it contains "Google Compute Engine"?
I.e., do we want "contains" or match the whole string?
Comment on lines
+41
to
+87
| /** | ||
| * Verifies that the standard IPv4 localhost address (127.0.0.1) is bound to a loopback interface. | ||
| */ | ||
| static boolean hasLocalIpv4Loopback() throws Exception { | ||
| return checkLocalLoopbackAddress("127.0.0.1"); | ||
| } | ||
|
|
||
| /** Verifies that the standard IPv6 localhost address (::1) is bound to a loopback interface. */ | ||
| static boolean hasLocalIpv6Loopback() throws Exception { | ||
| return checkLocalLoopbackAddress("::1"); | ||
| } | ||
|
|
||
| static boolean isIpPlumbed(InetAddress expectedIp) throws Exception { | ||
| if (expectedIp == null) { | ||
| return false; | ||
| } | ||
| Enumeration<NetworkInterface> interfaces = NetworkInterface.getNetworkInterfaces(); | ||
| while (interfaces.hasMoreElements()) { | ||
| NetworkInterface iface = interfaces.nextElement(); | ||
| if (!iface.isLoopback() && iface.isUp()) { | ||
| Enumeration<InetAddress> addrs = iface.getInetAddresses(); | ||
| while (addrs.hasMoreElements()) { | ||
| if (addrs.nextElement().equals(expectedIp)) { | ||
| return true; | ||
| } | ||
| } | ||
| } | ||
| } | ||
| return false; | ||
| } | ||
|
|
||
| private static boolean checkLocalLoopbackAddress(String expectedIp) throws Exception { | ||
| InetAddress expected = InetAddress.getByName(expectedIp); | ||
| Enumeration<NetworkInterface> interfaces = NetworkInterface.getNetworkInterfaces(); | ||
| while (interfaces.hasMoreElements()) { | ||
| NetworkInterface iface = interfaces.nextElement(); | ||
| if (iface.isLoopback() && iface.isUp()) { | ||
| Enumeration<InetAddress> addrs = iface.getInetAddresses(); | ||
| while (addrs.hasMoreElements()) { | ||
| if (addrs.nextElement().equals(expected)) { | ||
| return true; | ||
| } | ||
| } | ||
| } | ||
| } | ||
| return false; | ||
| } |
Contributor
There was a problem hiding this comment.
These methods are not used. Only isUp is used. Do we need them?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.