Skip to content

fix: cancel even when vrpc is not started yet and fix newRealCall#2897

Merged
mutianf merged 4 commits intogoogleapis:mainfrom
mutianf:sad_bugs
Apr 22, 2026
Merged

fix: cancel even when vrpc is not started yet and fix newRealCall#2897
mutianf merged 4 commits intogoogleapis:mainfrom
mutianf:sad_bugs

Conversation

@mutianf
Copy link
Copy Markdown
Contributor

@mutianf mutianf commented Apr 21, 2026

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@mutianf mutianf requested review from a team as code owners April 21, 2026 01:59
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/java-bigtable API. labels Apr 21, 2026
@mutianf mutianf changed the title fix: cancel even when vrpc is not started yet and fix newRea… fix: cancel even when vrpc is not started yet and fix newRealCall Apr 21, 2026
Change-Id: I81320830192df0cd16f405487c25b5dcb28985fe

if (!status.isOk()) {
if (!state.compareAndSet(State.STARTED, State.CLOSED)) {
return;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return is missing now. It was here to protect from the race with handleSessionClose, right? Then we should keep it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh. Do we want a user to have an exception if starting a call coincides with session closing? Am I missing something?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I think this only prevents double start of an vrpc which should never happen? session closing should be handled here: https://github.com/googleapis/java-bigtable/blob/main/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/session/VRpcImpl.java#L140 which we only log a warning if the state is not correct.

Change-Id: I1064ff6be95987c994360119c832e9e55abe60e5
Change-Id: I65308166955609dfc08ee0fec13987b469683dd0
@product-auto-label product-auto-label Bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Apr 22, 2026
@mutianf mutianf merged commit 45905a0 into googleapis:main Apr 22, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants