Skip to content

test(showcase): add bidi streaming generated code and integration test - #6275

Merged
suzmue merged 5 commits into
googleapis:mainfrom
suzmue:showcase-streaming-integration-stacked
Aug 5, 2026
Merged

test(showcase): add bidi streaming generated code and integration test#6275
suzmue merged 5 commits into
googleapis:mainfrom
suzmue:showcase-streaming-integration-stacked

Conversation

@suzmue

@suzmue suzmue commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Generate the prototyping showcase crate with bidi streaming methods enabled. The library code and its integration test are gated behind google_cloud_unstable_gapic_streaming.

For #2318

@suzmue
suzmue requested review from a team as code owners August 3, 2026 23:07
@suzmue

suzmue commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

If you look at the last commit, this will remove the clutter from updating the oneof conversions across the repo.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables bidirectional streaming methods for the showcase service in the Rust SDK, introducing the chat and connect streaming methods across the client, stub, tracing, and transport layers. It also updates several generated conversion files (BigQuery Write, Firestore, Spanner, Storage) to box certain enum variants. One issue was identified in the chat integration test where a silent pass could occur if the stream is empty; it is recommended to explicitly assert that a response is received.

Comment thread tests/showcase/src/echo.rs Outdated
@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.25%. Comparing base (8fea054) to head (c4a3be9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6275   +/-   ##
=======================================
  Coverage   96.24%   96.25%           
=======================================
  Files         280      280           
  Lines       72194    72194           
=======================================
+ Hits        69484    69488    +4     
+ Misses       2710     2706    -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread tests/showcase/src/echo.rs Outdated
Comment thread src/spanner/src/generated/convert/spanner/convert.rs
Comment thread src/generated/showcase/Cargo.toml Outdated
Comment thread src/generated/showcase/Cargo.toml
Comment thread src/generated/showcase/src/convert.rs Outdated
@suzmue
suzmue force-pushed the showcase-streaming-integration-stacked branch from 84029ac to bffa22f Compare August 3, 2026 23:57
@suzmue
suzmue marked this pull request as draft August 4, 2026 00:20
@suzmue

suzmue commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

Converted to draft since some of the issues need to be addressed upstream first: googleapis/librarian#7176

@suzmue
suzmue force-pushed the showcase-streaming-integration-stacked branch from 88ca59f to 925ee78 Compare August 4, 2026 21:52
@suzmue

suzmue commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

PR Status: On Hold

#6277 <- I want this to go in first so this PR doesn't get cluttered with shopping and bigquery changes.

@suzmue
suzmue force-pushed the showcase-streaming-integration-stacked branch from 925ee78 to c4a3be9 Compare August 5, 2026 18:15
@suzmue
suzmue marked this pull request as ready for review August 5, 2026 18:18
@alvarowolfx
alvarowolfx self-requested a review August 5, 2026 19:16
@suzmue
suzmue merged commit d36cd50 into googleapis:main Aug 5, 2026
41 checks passed
@suzmue
suzmue deleted the showcase-streaming-integration-stacked branch August 5, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants