chore(storage): fix order dependency in get_object_contexts test#34844
Open
aandreassa wants to merge 1 commit into
Open
chore(storage): fix order dependency in get_object_contexts test#34844aandreassa wants to merge 1 commit into
aandreassa wants to merge 1 commit into
Conversation
Currently this fails if the order is incorrect: ``` -Key: my-custom-key, Value: my-custom-value Key: my-custom-key-2, Value: my-custom-value-2 +Key: my-custom-key, Value: my-custom-value ``` Noticed in #34751
aandreassa
force-pushed
the
fix-storage-order-test
branch
from
July 16, 2026 22:04
c7d29af to
6789003
Compare
aandreassa
marked this pull request as ready for review
July 16, 2026 22:09
Contributor
Author
|
@bajajneha27 or @cpriti-os if I could get a LGTM on this flaky test. TY! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently this fails if the order is incorrect, introducing flakiness:
Noticed in #34751