chore: copy google-cloud-sql from googleapis-gen#8770
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces several updates to the Google Cloud SQL Node.js client, including the addition of the ResolveConnectSettings RPC, the new SqlDataService for bidirectional SQL data streaming, and various new configuration fields (such as performance capture thresholds and accelerated replica mode). However, the reviewer noted a critical issue: several newly exported service clients in both v1 and v1beta4 index files are missing their corresponding implementation files, which will lead to compilation and build failures.
| export { SqlAvailableDatabaseVersionsServiceClient } from './sql_available_database_versions_service_client'; | ||
| export { SqlBackupRunsServiceClient } from './sql_backup_runs_service_client'; | ||
| export { SqlBackupsServiceClient } from './sql_backups_service_client'; | ||
| export { SqlConnectServiceClient } from './sql_connect_service_client'; | ||
| export { SqlDatabasesServiceClient } from './sql_databases_service_client'; | ||
| export { SqlEventsServiceClient } from './sql_events_service_client'; | ||
| export { SqlFeatureEligibilityServiceClient } from './sql_feature_eligibility_service_client'; | ||
| export { SqlFlagsServiceClient } from './sql_flags_service_client'; | ||
| export { SqlIamPoliciesServiceClient } from './sql_iam_policies_service_client'; | ||
| export { SqlInstanceNamesServiceClient } from './sql_instance_names_service_client'; | ||
| export { SqlInstancesServiceClient } from './sql_instances_service_client'; | ||
| export { SqlOperationsServiceClient } from './sql_operations_service_client'; | ||
| export { SqlRegionsServiceClient } from './sql_regions_service_client'; | ||
| export { SqlSslCertsServiceClient } from './sql_ssl_certs_service_client'; | ||
| export { SqlTiersServiceClient } from './sql_tiers_service_client'; | ||
| export { SqlUsersServiceClient } from './sql_users_service_client'; |
There was a problem hiding this comment.
Several new service clients are exported here (e.g., SqlAvailableDatabaseVersionsServiceClient, SqlEventsServiceClient, SqlIamPoliciesServiceClient, SqlInstanceNamesServiceClient, SqlRegionsServiceClient), but their corresponding client implementation files (e.g., sql_available_database_versions_service_client.ts, etc.) are missing from this pull request. This will cause compilation/build failures. Please ensure all generated client files from googleapis-gen are copied over.
| export { SqlDatabasesServiceClient } from './sql_databases_service_client'; | ||
| export { SqlDataServiceClient } from './sql_data_service_client'; | ||
| export { SqlFlagsServiceClient } from './sql_flags_service_client'; | ||
| export { SqlIamPoliciesServiceClient } from './sql_iam_policies_service_client'; |
There was a problem hiding this comment.
The SqlIamPoliciesServiceClient is exported here, but its corresponding client file sql_iam_policies_service_client.ts is missing from the pull request. Please make sure to copy all generated client files.
1 participant
Copy google-cloud-sql from googleapis-gen.
Step to copy the code: